Date: Mon, 22 Oct 2018 12:12:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set pg_class.relhassubclass for partitioned indexes
Message-ID: <20181022031212.GF14282@paquier.xyz>
References: <E1gEPd3-0007fj-6U@gemulon.postgresql.org>
 <82470.1540177167@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xHbokkKX1kTiQeDC"
Content-Disposition: inline
In-Reply-To: <82470.1540177167@sss.pgh.pa.us>
Precedence: bulk


--xHbokkKX1kTiQeDC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 21, 2018 at 10:59:27PM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> Set pg_class.relhassubclass for partitioned indexes
>=20
> Seems like this commit should have touched the catalogs.sgml description
> for that column, as well as the pg_class.h comment for it.  Neither of
> those are worded in a way that suggests it could be set for non-table
> relations.

The pg_class.h comment looked fine for me first.  How would you reword
it?

relispartition tells "True if table is a partition", which is not
actually true as it can apply to indexes.  So this should be changed in
v11 as well, no?

For relhassubclass, perhaps we could do a bit more than just referring
to children...  What about the following:
"True if relation has (or once had) any inheritance children or
partitions"
Here is the current formulation:
"True if table has (or once had) any inheritance children"

And this should be changed in v10~ additionally?
--
Michael

--xHbokkKX1kTiQeDC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlvNQAwACgkQnvQgOdby
QH2gCA/+JbyaEilBepmTcOvsWaOl4OeOnZnNZN9605rKxfEPn9vwDY3vg3SEt2FL
xsrCuMYU5cnUnpGcU2gQzfMrhH6uGiKcUpj/FN7a4cdU+KAYpjoaf/sECGtulGdJ
1xfczxravZ/MM1G8ArHkXcx2kacefNl0hYC2s0eA3mDGUb0J2H4Jkmbk+lFsZ+Fh
H43jxQMYNdwffbVkNRW+R5WJiZsnZzhtKI3ehpU8dARALXwHImbkNNbTzQ++3bp9
YHlb66VTnTGizy4dZ5gtbk1b7Y9FgKndnrFKrgQM54zDmB8YkT66FHL2X9VG7OKr
qOgGirSugJZidUzmpW45PL0dxEcJDBnFgM5wYQm0xm1UMQJkyBTyv0XcV1PZO+kI
WjtRSZC1NfjMbDNR+82yDAKLdF9il5e0SJv5+xrj/ybkWeDTsgLArt25JxBYPdzo
evdk3twXblOQ+VXcDQVtG178ptqtUrGU/aD4Xlvx4qfHWkPOo9KRQssRl/nr9I/Y
EZalXXSnTWGH3wtlqiXj9e52Rd/T54AqEeE4aUoGa4i33KUDJunmFrdPdm6gMeML
6mOFMEv5ku9DTGg9pVGr3Ul2N5LMeW77YgEQd9uMElewvFRji7TlkSUHFZNn+Bvn
M7CYJBIU51H8qbZyAVJgZa+aETuzNolZqQUVkFdw3SHkA9EZsrc=
=Ug5W
-----END PGP SIGNATURE-----

--xHbokkKX1kTiQeDC--