Date: Sat, 19 Jan 2019 09:08:27 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Restrict the use of temporary namespace in two-phase
 transaction
Message-ID: <20190119000827.GB2660@paquier.xyz>
References: <E1gkHvw-00010c-3O@gemulon.postgresql.org>
 <20190118005949.GD1883@paquier.xyz>
 <25291.1547773687@sss.pgh.pa.us>
 <CA+TgmoZaCNTxXzV76zuyMuc8N9vU6RgEhVu8t9dXDcKqThUW7A@mail.gmail.com>
 <499.1547843670@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QKdGvSO+nmPlgiQ/"
Content-Disposition: inline
In-Reply-To: <499.1547843670@sss.pgh.pa.us>
Precedence: bulk


--QKdGvSO+nmPlgiQ/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 18, 2019 at 03:34:30PM -0500, Tom Lane wrote:
> Seems hard to avoid.  We could conceivably make it return "pg_temp"
> for the temp schema instead of the schema's actual name, but it's
> not very hard to think of ways whereby that would make use of the
> result fail in contexts where it previously worked.

CREATE EXTENSION is one such case.  It would not work if referring to
the synonym pg_temp, but it can work if using directly the temporary
namespace of the session.  So I feel that changing such things is
prone to break more things than to actually fix things.

> Another idea is to force creation of the temp namespace as soon as
> we see that search_path references it.  I'm not very sure exactly
> where would be a convenient place to make that happen, though.
> There are paths whereby the GUC's value will change outside a
> transaction, so we couldn't tie it directly to the GUC update.

This is documented at the top of namespace.c: "initial GUC processing
of search_path happens outside a transaction".
--
Michael

--QKdGvSO+nmPlgiQ/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxCansACgkQnvQgOdby
QH2emg//TJ60oiBjaJHbu1o6yJJvf+eZKyaKTdyX0pKXXeqFVlOG6xjZRo8r0W2n
m3jtbiOTIME0qeMahwasUofoOpy3lMO600nvkER7j/M45/a7lti8CbeOvo0lHc0H
vWLtMVA0bi7WuSs+xpUWyJw4ZSeU0y1xzhPU4I/2HaDIcdl4qNbJJKNHU5dviWdn
bxNSPklSpQkrzOfbGIGPamR5lnjE/EJsJCLOB7Zfh8E++Tzv7wv78KsCFa1IvUQ0
Opei/OqDj/M9VBIn9NAltetjgO93xYRcZWNMjfJoVRyWAK4pxlWvA2jIxPPIkq30
M/kTVV3daf9bgEcIwNZF/P71kY+UYOziFP7V3ensstTISXZHjVp24It8aReW0DKD
588Tga6t5ZByRbIk+LJshdQe1JO9luAFpsobvlwvLTnmps6b/VaUhbOcruao9E4d
LgaQO4tRnrEX1zDKxhXLNeM6iYsuRRKNue88f8AiU7EwP3tDpfRRwmNK7ko34Al6
SuKJH2zKsczbrNiu7fvEPt4x7IO9y1QM3wpHVljeB5HnEyyytPqm5uKZswIwc8aL
sZRIbaTynua8Iv8qWSkaiZYcwGioA4QIMjVyG/T4uZuUkSsusTj3FJV0qu3/eRvS
t3mVWwWBWFjS6CjtHy7Ebb2BD0OO5k5PySKO/3NV/cWgHrHfszU=
=wR3g
-----END PGP SIGNATURE-----

--QKdGvSO+nmPlgiQ/--