Date: Sat, 19 Jan 2019 10:12:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Restrict the use of temporary namespace in two-phase
 transaction
Message-ID: <20190119011200.GA3306@paquier.xyz>
References: <E1gkHvw-00010c-3O@gemulon.postgresql.org>
 <20190118005949.GD1883@paquier.xyz>
 <25291.1547773687@sss.pgh.pa.us>
 <CA+TgmoZaCNTxXzV76zuyMuc8N9vU6RgEhVu8t9dXDcKqThUW7A@mail.gmail.com>
 <499.1547843670@sss.pgh.pa.us>
 <20190119000827.GB2660@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1"
Content-Disposition: inline
In-Reply-To: <20190119000827.GB2660@paquier.xyz>
Precedence: bulk


--RnlQjJ0d97Da+TV1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 19, 2019 at 09:08:27AM +0900, Michael Paquier wrote:
> On Fri, Jan 18, 2019 at 03:34:30PM -0500, Tom Lane wrote:
>> Seems hard to avoid.  We could conceivably make it return "pg_temp"
>> for the temp schema instead of the schema's actual name, but it's
>> not very hard to think of ways whereby that would make use of the
>> result fail in contexts where it previously worked.
>=20
> CREATE EXTENSION is one such case.  It would not work if referring to
> the synonym pg_temp, but it can work if using directly the temporary
> namespace of the session.  So I feel that changing such things is
> prone to break more things than to actually fix things.

As long as I don't forget about it..  current_schema() is classified
as stable, so it's not like we can make it return pg_temp and then the
real temporary schema name within the same transaction...
--
Michael

--RnlQjJ0d97Da+TV1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxCeWAACgkQnvQgOdby
QH0Low//VReO9BvtW4bLA016LS6yumf4TaNscszPxbr+9dLRECaE26LBJh+LSR+8
jviehbaUXira6DASz7/x/gWMbqOzYAmSvgVl5mwkoJmLNNkjkrsKSn60c5oVL9TB
8RhTXa/Qm2yocT5iPXyk0IDUlw3s2WOh5vXYqD36S9Q+Hc4a2Y0dvb4gkPoaZSbA
8Z/sbHFvqB5JyOJH93rnxElxl2cR1TGQKZ7HItIoQgE6DPQX6Si8C9pag2zPyeV1
FYeZQpigeURR5V6s3VZKTyU+wl/UuE/wEo/XJDMHu1y1/oBPAt/5ZKpUXQhdoXfc
rbcRGu9CIFqFSzv+MSxlS5s2QeHajqa3Posng8ebv6fPmwRnT7K6riGm5PxNmkBv
fWy/dyafT5mEknk0rPoUucln7IRH2jBTqXjdBQOX7daPWUbX6riPpyaElhXyeAVg
AbmF6C8bnkMdHAhylMxLvTNFZTwbgh3opLdPn0FX7+WBVkTbbgSuQHyoq7vPpK1s
mJPsdeCA8E17XZjXteQR4UMMB9rLqkY/B4UNjEYemViyooR+vLt+R21whrlRzgcf
rH/FTceQXZEJN7lGS7qPwRUUhFBaBMg7mDUuXHhvHzwqCX/0NanzFg8uH8Cee2iU
3bHGP4pcN+LKoF4T65hkKdTkDjfT+ullbiuXYRhUchyjoywFxBw=
=PhiT
-----END PGP SIGNATURE-----

--RnlQjJ0d97Da+TV1--