Date: Mon, 11 Mar 2019 10:11:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Include GUC's unit, if it has one, in out-of-range error
 message
Message-ID: <20190311011114.GD1818@paquier.xyz>
References: <E1h33xk-0001Og-Gs@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="oj4kGyHlBMXGt3Le"
Content-Disposition: inline
In-Reply-To: <E1h33xk-0001Og-Gs@gemulon.postgresql.org>
Precedence: bulk


--oj4kGyHlBMXGt3Le
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 10, 2019 at 07:18:20PM +0000, Tom Lane wrote:
> Include GUC's unit, if it has one, in out-of-range error messages.
>=20
> This should reduce confusion in cases where we've applied a units
> conversion, so that the number being reported (and the quoted range
> limits) are in some other units than what the user gave in the
> setting we're rejecting.
>=20
> Some of the changes here assume that float GUCs can have units,
> which isn't true just yet, but will be shortly.

It does not seem to have cooled down all animals yet, whelk is
still complaining:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dwhelk&dt=3D2019-0=
3-11%2000%3A41%3A13

-ERROR:  -Infinity is outside the valid range for parameter "geqo_selection=
_bias" (1.5 .. 2)
+ERROR:  invalid value for parameter "geqo_selection_bias": "-infinity"

It would be nice if we could avoid an alternate output.
--
Michael

--oj4kGyHlBMXGt3Le
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlyFtbIACgkQnvQgOdby
QH2CPg//Uz3lEZR+rbcu3HEivG4KlVFLPw8oFSvuTEXw/B299PD3kPYs+FsGmCww
IrbqRchBS6U6xcJspHlyEkn/WvOk+tGgDAkwtYWwCq5RP4YMaPSLx5bH2rrRf9VT
0EQDZIUABcn7755H5wsLLGy3yPHBBZzvQT/T5uQ8TrVxCFG0zs9H3bqGr5kx5XZj
sM01tjGcZvZKLJ6N2DliidzQqUjBk/GvbymJCAkfbZ1poo/4sT9JSy28dER+tvYg
PcoNPjicjXgWYPkLlAh8G9QOqEbNnWmSDk0vpomCiNiKxnoGtPygmR29QBFZQdzm
kuCVbSQajphBgGDTJ+F/CteA6VTss8KLDAXQ961nTchFod3FCN1AHuILHsa43Few
AVxPNnxDiLW1d+7h4JyNrYaErMRWRxyhWQNgS+UmE9jQh0u25Hykf20Na/ASCDlL
/tA7Ac3M27p1uewP4pIFfvg6W/8ORdVTV2zRM8Roi5OLheSL9KaBn/y8d2PlI9CX
mZqmJciSCdzrqln5Hs3fSIYObUzKXdWkpnXqh/yzFITxTBLREEpz8wRFzoBVj0DK
sBtNp9WaETDfabuDShQGVQSJPN9Yy9UYVMJrpEyrPCLBnamPI1IA5U9WPwb+Gyz6
nLJKUsYkKVjIVzvej3dfpSf/FzlPNfypYmZ7sh6Vfkgf7N/hK1E=
=fMii
-----END PGP SIGNATURE-----

--oj4kGyHlBMXGt3Le--