Date: Fri, 22 Mar 2019 13:12:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	pgsql-committers@lists.postgresql.org
Subject: Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to display
 top-most parent of a partition
Message-ID: <20190322041225.GS20192@paquier.xyz>
References: <E1grthW-00078n-Az@gemulon.postgresql.org>
 <20190322032612.GA323@alvherre.pgsql>
 <20190322035538.GO20192@paquier.xyz>
 <06be11a6-fd8d-b68b-1b97-1bafb1d3185c@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mmR5Tf+WJGm+vTLg"
Content-Disposition: inline
In-Reply-To: <06be11a6-fd8d-b68b-1b97-1bafb1d3185c@lab.ntt.co.jp>
Precedence: bulk


--mmR5Tf+WJGm+vTLg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2019 at 01:09:23PM +0900, Amit Langote wrote:
>  	/* Fetch the top-most parent */
>  	ancestors =3D get_partition_ancestors(relid);
>=20
> Maybe, the patch should update this comment to say "Fetch the list of
> ancestors".

Perhaps so.  Note that actually the list is fetched to grab the
top-most parent from it, so it sort of makes sense?

> What does "listed partition" mean?  Maybe, you mean "If the input
> relation..."?  How about write this as:

Input relation sounds better.
--
Michael

--mmR5Tf+WJGm+vTLg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlyUYKkACgkQnvQgOdby
QH2Y2A/8DZZ50fVTYcW811aRaE5sI8c6pVDuwZ7/bDcouGfD0bTUvex3Ow3pWDLY
Qc6h+r00fT6IBTB0UYAgrCl+9DuFz5MMv2Dhs06V8Z6N/98KGKT0+8buWQaJpci3
nd504jiPuJd/dLY0+5GLeDOvLCmXFfUdPynKJuloyBAZXfWSbtNAW2oLmXNvY2ge
z+Dx+dfUnftXdOJfm1n/q/rWky/5qx70jHVCBC5YRY+s6VLBXaDmet/H/zgQnXKi
ilt1NK7muF+7QW7MzAAG2zx/Xc8ZaFhgco8Vug89ICgraOB6rh/pTM17h3XCA2Ws
4qnUwmNdZNB81HAXopVEH5zOk3M2/KZRzJOZ236o2BWtPSpQ4W5MmbqrxaQ0hy+/
JN/AR9Y0ePv+pIqwRNDPGjWDLePEsBXUoHJ3u68Q1yNpKwgVyEw/NqezZhOVEqCs
7g42o4HwNrK2uScU8ngAwg/JjyXrWQd6c3nid37Q2KE1M5gBp2ggqhcZIN+HT9bm
+Dh92wSs8gwBYcJa+SROdDK8nk5UyVHgutGzMp16WGBgNMntpUCuyn7Rzm+OveDh
YjbBOB7HL38rPvrSv9L22szRZ1Yq5pEhMAeLe2R5pqayjgnRV1QFv2frNDHGRNTB
KwawMZuKf56M44jhF1tZLtVzvSEN7K/S+IrXpzIJed25/ZLvlfE=
=5mBD
-----END PGP SIGNATURE-----

--mmR5Tf+WJGm+vTLg--