Date: Fri, 29 Mar 2019 23:03:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	sawada.mshk@gmail.com, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com,
	sk@zsrv.org, nasbyj@amazon.com, andres@anarazel.de,
	robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Improve autovacuum logging for aggressive and
 anti-wraparound ru
Message-ID: <20190329140349.GI1954@paquier.xyz>
References: 
 <CAD21AoBR+y31ps+=G6_fxxVd_o1itTnaK19sDAEhAP_RyVT2AA@mail.gmail.com>
 <20181005031603.GF1629@paquier.xyz>
 <20181005063504.GB14664@paquier.xyz>
 <20181009.181536.142257785.horiguchi.kyotaro@lab.ntt.co.jp>
 <920b7f84-407c-005c-4b7d-e8266a17d22b@2ndQuadrant.com>
 <20190309011537.GD9266@paquier.xyz>
 <20190329115138.GD1954@paquier.xyz>
 <e454b280-d7b5-1798-b01c-213b663d8907@2ndQuadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IJFRpmOek+ZRSQoz"
Content-Disposition: inline
In-Reply-To: <e454b280-d7b5-1798-b01c-213b663d8907@2ndQuadrant.com>
Precedence: bulk


--IJFRpmOek+ZRSQoz
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 29, 2019 at 09:11:47AM -0400, Andrew Dunstan wrote:
> +=A0=A0=A0 =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 (errmsg_internal("found vacuum t=
o prevent wraparound of
> table \"%s.%s.%s\" to be not aggressive, so skipping",
>=20
> This might convey something to hackers, but I doubt it will convey much
> to regular users. Perhaps something like "skipping redundant
> anti-wraparound vacuum of table ..." would be better.

"skipping redundant" is much better.

> The comment is also a bit too tentative. Perhaps something like this
> would do:
>=20
>     Normally the relfrozenxid for an anti-wraparound vacuum will be old
>     enough to force an aggressive vacuum. However, a concurrent vacuum
>     might have already done this work that the relfroxzenxid in relcache
>     has been updated. If that happens this vacuum is redundant, so skip i=
t.

That works for me.
--
Michael

--IJFRpmOek+ZRSQoz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlyeJcUACgkQnvQgOdby
QH0LyhAAibv4rW+gK/VRzvNRw9X7Kp/j1gArVJurKW68k39lXyWj9TEzQg3hoR6k
bTQULaiVNjj77rBvgD8W78DrvDax5EwG/dil3YNprDKOKFUBtuyIO9kWPtLxSNk6
pECxBppHVdp40Wc/rqqseYQeU+beFDPz8wUDNrWLXpWkrky67/xaMlJ7E4NHqpGM
FMz0gPOVTXe7zgE48OTXM/Wl/bNG0BFGzVbVdGg4vsbVaz5LDQcmocPNzCxCzi1a
7qAcPd6IsC0u+204uCAMXYjwKpS/cjLl20YoaB+E6C1Nkty8Xnc20wIgCSgmfO/f
yFBHnyG1FtpLgG2HOn8F1ZL462yiN82ZemMwMFlwHOMhJ22chGM1XlMAzfWjLgJY
AfbCnGEsCRlbCkZvKg+co0JC5TWsmJRINK/B7sbo9TkXTxSHO8VWjD5bjovlT4v4
iKCU45V2SF8ckUZyn7b7yme5NSfLoNv7aelDR/foUdGOolCiQwMsoV1ZQO1wp6e0
rage/Z/rHDWIbmXV3vRveCcUlC4wjw6Pu+YLoVIINz8DU2iv+51VYoP6x0C3MTxi
cghlJTrUX3io6dZ4WyQiJM13zfugw/vRoZeYPHKXiDFsbvpECQ7ozHv43l96Oie/
Qeg/HEVilijJ88yzWdyqaBg2wdxvFT+hj2ERCZev2D7B2ce34mE=
=un6b
-----END PGP SIGNATURE-----

--IJFRpmOek+ZRSQoz--