Date: Sat, 30 Mar 2019 10:08:22 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
	Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	sawada.mshk@gmail.com, tgl@sss.pgh.pa.us, sk@zsrv.org,
	nasbyj@amazon.com, andres@anarazel.de, robertmhaas@gmail.com,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Improve autovacuum logging for aggressive and
 anti-wraparound ru
Message-ID: <20190330010822.GL1954@paquier.xyz>
References: <20190329140349.GI1954@paquier.xyz>
 <20190329142255.GA22447@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="zROEGoKAXsG5UqGB"
Content-Disposition: inline
In-Reply-To: <20190329142255.GA22447@alvherre.pgsql>
Precedence: bulk


--zROEGoKAXsG5UqGB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 29, 2019 at 11:22:55AM -0300, Alvaro Herrera wrote:
> Yeah, that looks good to me too.  I wonder if we really need it as LOG
> though; we don't say anything for actions unless they take more than the
> min duration, so why say something for a no-op that takes almost no time?
> Maybe make it DEBUG1.

I think that this does not justify a WARNING, as that's harmless for
the user even if we use WARNING for other skips (see
vacuum_is_relation_owner).  However DEBUG1 is also too low in my
opinion as this log can be used as an indicator that autovacuum is too
much aggressive because there are too many workers for example.  I
have seen that matter in some CPU-bound environments.  I won't fight
hard if the consensus is to use DEBUG1 though.  So, more opinions?
Andrew perhaps?

> s/relfroxzenxid/relfrozenxid/

Sure.
--
Michael

--zROEGoKAXsG5UqGB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlyewYYACgkQnvQgOdby
QH2FmA/+IcwztB/aKCSEPb7oWBrd8UcWsm3SVC7fCADzQOMY35TnXVBgZDaa5tth
vWV6gtrsPOvUny+wcXV3QREWwPEmDHu938O+BA8IgkDC2f32AnMPxnA87aeb7haT
DByotD8wRMj98+zqf6ZFnjGNT8KFWm3q5QltOtcAjOpyyTm7RmPP9te+hLBhgtks
Bpv3+pkVLldGocVPK5MEyjtsQzIuJtz9+UxEPEnfxnGb7faDbXxoYqbXS58549qE
03D8Ev5S3h9csKkKvK4pYPUkO7Pmzq/DfTrq/pdiIB+eNWBYabEuFffeA39PW0zC
C8Pg1yV3+VrxHDSabj/XK2cqS/aygQ6ohc5euvN+C5cQuiZwUvskz+G8+91dfy2y
L7AsIIHBE9rPNowL7ZQXhYZRZntN9icSp+hH/X8EStbEfBfvgq2N0cusY7f4EitI
WesN1bpq49cKfOUCJl+b/mKhob80cFPmAShcJLR5Sak0rB5FVi/gGPVGCY6GhE04
MGuBxzpvG5WQE2xNviVy6HFNYWKxnu3nrHT0QRaXVaNuX4lb6HHjTRH4tzJxUzRN
Wbkt3kpiHvB1xUZ6KxBzFFOYrXNiNXxv0WVCMdzCm6bv25co3NlBaPWvSN2gmxzL
YS7WqfrEZwqej7++wJh30uKv1bFmANkCV6w1BQ90aZdg4XFPz6g=
=xObF
-----END PGP SIGNATURE-----

--zROEGoKAXsG5UqGB--