Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLVhI-0007Di-W0 for pgsql-committers@arkaria.postgresql.org; Tue, 30 Apr 2019 16:33:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hLVhH-00019v-Nl for pgsql-committers@arkaria.postgresql.org; Tue, 30 Apr 2019 16:33:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLVhH-00019n-8P for pgsql-committers@lists.postgresql.org; Tue, 30 Apr 2019 16:33:35 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLVhE-0003zW-9t for pgsql-committers@lists.postgresql.org; Tue, 30 Apr 2019 16:33:34 +0000 Received: by mail-wr1-x443.google.com with SMTP id r6so21794793wrm.4 for ; Tue, 30 Apr 2019 09:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fGOKJTmPpcQ9MdGvSWjrNZOKux/uEQDqbHy+3T2ZuAo=; b=BxAhlz7jU3/XkNMRL2t49MYG0GrDWKLzHJWeUMTqLpFND+qeJ/D/ZHIJoeULhJZVuz R+52AFgorYncTAwnIDDK1BGB/q+S4z6/c1LR14raN6SVPjSjPGXYR49ovrz999eyWP4Y ZYH82fSLqMGy/1kx/RR22KO2pUdLVS+OWJCt1xcdk5uQ+xIIKDb0OP5Tc7SxvpEjQmxz mxmQfHvPT7kbBYjCrqchwPfC6w6LCmLgGFVhy9r2H4IoCeMiKy0FoUOaI6PnQRhxIrFE E7IknGoWfu4DWBlfhcUrEqn5RigEi5koclxGr/GUD2q6C0erA9sorZNkOpCPJy2tVTRW 3aeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fGOKJTmPpcQ9MdGvSWjrNZOKux/uEQDqbHy+3T2ZuAo=; b=WHx/0RHg/7wSDKKJ8Y+qfLbkdTmCrrz3Z/j4EOWiqpqnlVFhIK55H0yFfjdbQi6ldY 3dz1epNhtvVVvKogWjl8dJOI2u3S2tB4KmlzK/HnEVUTRMMh2jxn1XhGRdjYvLHJL5j8 JV9s8fnhboZ5iIlqZmVvjnA3YjVcU50rg063+VRtKbD32RSBMRiIQqbvttQ3pLIwlGH5 lEEPgBiOOjiZgdniF0wgZ+XM8kWi4hGBmj3LXDdp5EzUhuAhoR1IGVBi6ilHxyMIss6J Mr3pIThORTxMWQ/uYsfkzFnBy4QGLfa9AOvOldywUshZIbyG3SrMRZTiSlYddVZi00tb TsEg== X-Gm-Message-State: APjAAAXkBixu5xtzQVovHnY74LLIQwoEYqU0zVds5LPSQWGuXMizBz1s OPk+9DA9xwoplrqqQjB6Ib7wGH332pg= X-Google-Smtp-Source: APXvYqzzYD5yzlop75UxgtCGWnH2kMcVZgdYIgWceOPYOyAqbZnRl2Udx69/OsenKu19Qk28a1V1Dw== X-Received: by 2002:a5d:49d2:: with SMTP id t18mr12787669wrs.111.1556642010561; Tue, 30 Apr 2019 09:33:30 -0700 (PDT) Received: from localhost (static-84-42-175-93.net.upcbroadband.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id a22sm2817354wmb.47.2019.04.30.09.33.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Apr 2019 09:33:29 -0700 (PDT) Date: Tue, 30 Apr 2019 18:33:28 +0200 From: Tomas Vondra To: Magnus Hagander Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Track block level checksum failures in pg_stat_database Message-ID: <20190430163328.zd4rrlnbvgaqlcdz@development> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-1444-295967-dirty List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Sat, Mar 09, 2019 at 06:48:11PM +0000, Magnus Hagander wrote: >Track block level checksum failures in pg_stat_database > >This adds a column that counts how many checksum failures have occurred >on files belonging to a specific database. Both checksum failures >during normal backend processing and those created when a base backup >detects a checksum failure are counted. > It seems this commit forgot to add PgStat_MsgChecksumFailure to the PgStat_Msg union. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services