Date: Sun, 19 May 2019 14:54:50 -0700
From: Andres Freund <andres@anarazel.de>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: In the pg_upgrade test suite, don't write to
 src/test/regress.
Message-ID: <20190519215450.b6b3mww3mwljurhc@alap3.anarazel.de>
References: <E1hSTXv-00076D-Pa@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1hSTXv-00076D-Pa@gemulon.postgresql.org>
Precedence: bulk

Hi,

On 2019-05-19 21:40:43 +0000, Noah Misch wrote:
> In the pg_upgrade test suite, don't write to src/test/regress.
> 
> When this suite runs installcheck, redirect file creations from
> src/test/regress to src/bin/pg_upgrade/tmp_check/regress.  This closes a
> race condition in "make -j check-world".  If the pg_upgrade suite wrote
> to a given src/test/regress/results file in parallel with the regular
> src/test/regress invocation writing it, a test failed spuriously.  Even
> without parallelism, in "make -k check-world", the suite finishing
> second overwrote the other's regression.diffs.  This revealed test
> "largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
> 
> Buildfarm client REL_10, released forty-five days ago, supports saving
> regression.diffs from its new location.  When an older client reports a
> pg_upgradeCheck failure, it will no longer include regression.diffs.
> Back-patch to 9.5, where pg_upgrade moved to src/bin.
> 
> Reviewed by Andrew Dunstan.

The buildfarm decidedly is not a fan of this:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spurfowl&dt=2019-05-19%2021%3A43%3A32

Greetings,

Andres Freund