Date: Mon, 20 May 2019 09:36:52 -0700
From: Andres Freund <andres@anarazel.de>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Fujii Masao <fujii@postgresql.org>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
Message-ID: <20190520163652.l7ibpe52pbq6lecc@alap3.anarazel.de>
References: <E1hSk9C-0002hH-Vp@gemulon.postgresql.org>
 <26460.1558366996@sss.pgh.pa.us>
 <CAHGQGwEvM9X66Ni4OKv4dOQQddw7z=cNUxnG=wEv84sqj9t_ig@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAHGQGwEvM9X66Ni4OKv4dOQQddw7z=cNUxnG=wEv84sqj9t_ig@mail.gmail.com>
Precedence: bulk

Hi,

On 2019-05-21 01:03:06 +0900, Fujii Masao wrote:
> On Tue, May 21, 2019 at 12:43 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Fujii Masao <fujii@postgresql.org> writes:
> > > Make VACUUM accept 1 and 0 as a boolean value.
> >
> > This was not a particularly great thing to be pushing on a release
> > wrap day, and pushing it without having even run the core regression
> > tests was downright negligent.  Please fix or revert, NOW.
> 
> Sorry, this is my shameful fault.. Attached is the patch for fix.
> I will commit this after confirming that regression test reports
> no error.

This was 30min ago. I've now pushed test adjustment, so the buildfarm
becomes green again. Still should either add some tests for the change,
or be revert.

Greetings,

Andres Freund