Date: Mon, 20 May 2019 09:49:08 -0700
From: Andres Freund <andres@anarazel.de>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Fujii Masao <fujii@postgresql.org>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
Message-ID: <20190520164908.t653bdbfjcn3d35p@alap3.anarazel.de>
References: <E1hSk9C-0002hH-Vp@gemulon.postgresql.org>
 <26460.1558366996@sss.pgh.pa.us>
 <CAHGQGwEvM9X66Ni4OKv4dOQQddw7z=cNUxnG=wEv84sqj9t_ig@mail.gmail.com>
 <20190520163652.l7ibpe52pbq6lecc@alap3.anarazel.de>
 <CAHGQGwEixkoMJy4JHUvBdM0MacR1_h=wmE43KTOTErpA2Z5P0w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAHGQGwEixkoMJy4JHUvBdM0MacR1_h=wmE43KTOTErpA2Z5P0w@mail.gmail.com>
Precedence: bulk

Hi,

On 2019-05-21 01:43:35 +0900, Fujii Masao wrote:
> On Tue, May 21, 2019 at 1:36 AM Andres Freund <andres@anarazel.de> wrote:
> > On 2019-05-21 01:03:06 +0900, Fujii Masao wrote:
> > > On Tue, May 21, 2019 at 12:43 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > > >
> > > > Fujii Masao <fujii@postgresql.org> writes:
> > > > > Make VACUUM accept 1 and 0 as a boolean value.
> > > >
> > > > This was not a particularly great thing to be pushing on a release
> > > > wrap day, and pushing it without having even run the core regression
> > > > tests was downright negligent.  Please fix or revert, NOW.
> > >
> > > Sorry, this is my shameful fault.. Attached is the patch for fix.
> > > I will commit this after confirming that regression test reports
> > > no error.
> >
> > This was 30min ago. I've now pushed test adjustment, so the buildfarm
> > becomes green again. Still should either add some tests for the change,
> > or be revert.
> 
> Thanks for the commit! And sorry, make check-world took very long time
> and has just finished right now in my env... I'd like to confirm that
> make check-world reports no error just in case.

make -j16 -s && make -Otarget -j10 -s check-world && echo success || echo fail

makes that much more bearable, by running the slow TAP tests in
parallel. Doesn't work < 10 though.

Greetings,

Andres Freund