Date: Tue, 21 May 2019 09:00:20 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>,
	Michael Paquier <michael.paquier@gmail.com>,
	Fujii Masao <masao.fujii@gmail.com>,
	Fujii Masao <fujii@postgresql.org>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
Message-ID: <20190521160020.wckjt7ggkwzwr4cj@alap3.anarazel.de>
References: <20190520163652.l7ibpe52pbq6lecc@alap3.anarazel.de>
 <CAHGQGwEixkoMJy4JHUvBdM0MacR1_h=wmE43KTOTErpA2Z5P0w@mail.gmail.com>
 <20190520164908.t653bdbfjcn3d35p@alap3.anarazel.de>
 <23559.1558374415@sss.pgh.pa.us>
 <20190520180027.zyxosts5yrf2i7mh@alap3.anarazel.de>
 <24497.1558375780@sss.pgh.pa.us>
 <20190520203505.zoeitjlehqypgx26@alap3.anarazel.de>
 <21766.1558397960@sss.pgh.pa.us>
 <20190521004717.qsktdsugj3shagco@alap3.anarazel.de>
 <15696.1558448457@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <15696.1558448457@sss.pgh.pa.us>
Precedence: bulk

Hi,

On 2019-05-21 10:20:57 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2019-05-20 20:19:20 -0400, Tom Lane wrote:
> >> The other thing I had to do below was to suppress "NOTICE: database
> >> "regression" does not exist, skipping".  The added createdb is a
> >> mighty expensive and grotty way to do that, but I didn't immediately
> >> see a better one.
> 
> > Hm. Perhaps we ought to just have pg_regress set client_min_messages to
> > something less noisy when running DROP DATABASE? I don't think any
> > pg_regress caller benefits from having it.
> 
> The least invasive way to do that seems to be as attached, building a
> little knowledge into pg_regress's psql_command() function.  Alternatively
> we could add a "bool quiet" parameter to that function so that callers
> had to say what to do, but I'm not sure that's an improvement.

It's not overly pretty, but also not that bad. I was wondering whether
we could make psql_command accept multiple statements (annoying due to
argument passing - although I guess we could switch to using numeric
references to arguments), use putenv to put client_min_messages into
PGOPTIONS (to finnicky to remove again), have psql_command pass the
command to psql via stdin (more code needed for pipe setup). So I think
we can just go with what you're proposing. Although I also could just go
with always supressing notices in psql_command().

Greetings,

Andres Freund