Date: Tue, 4 Jun 2019 10:13:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix contrib/auto_explain to not cause problems in
 parallel worke
Message-ID: <20190604011354.GD1529@paquier.xyz>
References: <E1hXv5x-0002VX-HF@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yudcn1FV7Hsu/q59"
Content-Disposition: inline
In-Reply-To: <E1hXv5x-0002VX-HF@gemulon.postgresql.org>
Precedence: bulk


--yudcn1FV7Hsu/q59
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Tom,

On Mon, Jun 03, 2019 at 10:06:21PM +0000, Tom Lane wrote:
> Fix contrib/auto_explain to not cause problems in parallel workers.
>=20
> A parallel worker process should not be making any decisions of its
> own about whether to auto-explain.  If the parent session process
> passed down flags asking for instrumentation data, do that, otherwise
> not.  Trying to enable instrumentation anyway leads to bugs like the
> "could not find key N in shm TOC" failure reported in bug #15821
> from Christian Hofstaedtler.

This has broken the builds on Windows for 9.6 and 10:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Dwoodlouse&d=
t=3D2019-06-04%2000%3A42%3A07&stg=3Dmake

Here is the failure:
auto_explain.obj : error LNK2001: unresolved external symbol
ParallelWorkerNumber [C:\buildfarm\buildenv\REL_10_STABLE\pgsql.build\auto_=
explain.vcxproj]

This gets included as a dependency because of the call to
IsParallelWorker() you have added in this commit, and I think that
this can be fixed by adding PGDLLIMPORT to the variable in
parallel.h.  Would you fix it or should I?
--
Michael

--yudcn1FV7Hsu/q59
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlz1xdIACgkQnvQgOdby
QH1knw//ewT2IspdMK8EluZKx6Bp+Kpgh2qVQ5xkvgIMD6Jh8d38NDoH30AoAw0f
845SUlxwE/sdmxUfWcrDqD7d+SLNDN8nVYMWOHO37Na20gSrypwrVBjbHctlUPtD
Xhxy2haOVOob1ru3XXP4lzLTEoczVBB6+xyZoJz6W5oH43wVaKne7Nb85wFkMZUN
zF3GJf5E84mFgzzxf35yQTKugAdmcr6/c93BukDjzD2bj4xLJJwVqTM7SdppiaSx
dPSh2HF3hwgXKC2yi8LQwGXQawnYlFYXKDb1SugTbFW8XjrrnGxjgjK8fSkgs6Wn
O+ct6W/kLrsjN2GIviyJDbSR2DAlZv+FGFBEBM9K/2b9ku/tYtfrE1bmww1XyJzA
+YHxrKE55d8usxWZk0MOJasagIUqcv0YFbt/Q6zMyGUPcendqq84uMBO0O+vRNpC
8LwD0riJtvnzFMu+fXWqRfEpq137usjSaNOLtgvcyIWow3qO0nEY4KpIMX7nmOX4
ba9CaP+zr97uWrXqQ+4HB9ak0I+2RGNHBnRxJJ5+H8svdzs2/elMaWp3hu3RtTfz
Il6iEal3eSDNohC9MUkZDTycEcyqDv1lBS6Z6DESVpJioVlcqh8Oa7mv02ob1gQ8
PAXXVsce/RsAfUxUJQlCx9iPwjtRaWD54M+qwUuNSukedouQn9A=
=4qY5
-----END PGP SIGNATURE-----

--yudcn1FV7Hsu/q59--