Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1hbnrO-0006qV-Kg
	for pgsql-committers@arkaria.postgresql.org; Fri, 14 Jun 2019 15:11:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1hbnrN-0004pY-1n
	for pgsql-committers@arkaria.postgresql.org; Fri, 14 Jun 2019 15:11:21 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hbnrM-0004ma-JC
	for pgsql-committers@lists.postgresql.org; Fri, 14 Jun 2019 15:11:20 +0000
Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hbnrE-0004QC-GS
	for pgsql-committers@lists.postgresql.org; Fri, 14 Jun 2019 15:11:18 +0000
Received: by mail-qk1-x743.google.com with SMTP id t8so1891723qkt.1
        for <pgsql-committers@lists.postgresql.org>;
 Fri, 14 Jun 2019 08:11:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=1ZtKtXxOdGk+YsgLXcCocD+ebNiZhrtR9UnN/sBKGYI=;
        b=ExBfoPYu9AfrQsC9Jgvp1RePVHlkvvrrlgqssMCGgDv2mqu+06K/vApf2mL545SIUr
         6EnmqM6HZa1xWGD0HqZYr98FYAKfoHFh5iRCFTlqCvIlp2NaShfSgYymLhnfHdgJxSP6
         kSKqMwnka9qSVASip2ps/tu0a7yb+79oe+Mq59qsVD8kmBStYCE8QNCnCz/waHnGbvcP
         o/2PI5lnDKZbkZfNCDDQOP3OT9HrR6uD5PYmTH9wDAxQorjIELLL5AjWrWMjwwLDSHbW
         xdVkkQ2Sih49SrIjvHJV+2r2OPThAuCHYuv9cVLCaoCE158AAMZqG6/ab7pqX+vi4A+4
         YV8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=1ZtKtXxOdGk+YsgLXcCocD+ebNiZhrtR9UnN/sBKGYI=;
        b=Bp34C9Ii2rNax78rii6lNZvaS9dAUJ3NrTADsGAucO28Kh6mw3TEOYQx//nsQbwU2R
         sMTyOHjjMFBEhTA9WGP4JfCCvbNoZGtTTXrTZbUZf0JYH3ynXQ34e+kcf2pMihwcsl0U
         ViEYiQMqmC9WQNQPqSUGHfy4B9Lm+67xlGQaAAKFGdbsTXp8JNExSkMzuUhGZtIrS6IM
         YqdYhf1uSiRNlGUgN8z/v0tl3iRlf2o8qSQ5mGh8J0EFWGUXuuZv359lE2Odd4+Sh1so
         EZZP0z9a1ZKqdiVQCx+pn/bBy7NqWXJc8CTHr8kbinjHY1O0H8dmf08ehLiw4Jpmu4as
         QswQ==
X-Gm-Message-State: APjAAAXeLxU2oYZI7rIE92EEuTF0MPnSldas+/YExqFCJpEA+bETzBuA
	tHJtR+vODcR82VLHQP46U04xkw==
X-Google-Smtp-Source: 
 APXvYqwYRMp+79Feevvbj0gDg3oDJlluSBl9HFjFYUyinfFt4pllJhH0U7IL4l7s2Eu2QYWllwnEVg==
X-Received: by 2002:ae9:e842:: with SMTP id
 a63mr73483140qkg.143.1560525071438;
        Fri, 14 Jun 2019 08:11:11 -0700 (PDT)
Received: from nimloth.alvh.no-ip.org ([179.56.48.227])
        by smtp.gmail.com with ESMTPSA id
 c18sm1447042qkm.78.2019.06.14.08.11.10
        (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
        Fri, 14 Jun 2019 08:11:10 -0700 (PDT)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 211D9120BC3; Fri, 14 Jun 2019 11:11:09 -0400 (-04)
Date: Fri, 14 Jun 2019 11:11:09 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org,
	Etsuro Fujita <etsuro.fujita@gmail.com>
Subject: Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock
Message-ID: <20190614151109.GA12229@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2815.1560521451@sss.pgh.pa.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

On 2019-Jun-14, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Avoid spurious deadlocks when upgrading a tuple lock
> 
> I'm now getting
> 
> heapam.c: In function 'heap_lock_tuple':
> heapam.c:4041: warning: 'skip_tuple_lock' may be used uninitialized in this function

Hm, I don't get that warning.  Does this patch silence it, please?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services