Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hchLU-0001Sd-Fc
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jun 2019 02:26:08 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hchLS-00013G-FE
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jun 2019 02:26:06 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hchLS-000109-1m
	for pgsql-hackers@lists.postgresql.org; Mon, 17 Jun 2019 02:26:06 +0000
Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1hchLN-0000R8-IY
	for pgsql-hackers@lists.postgresql.org; Mon, 17 Jun 2019 02:26:05 +0000
Received: by mail-qt1-x842.google.com with SMTP id w17so2600401qto.10
        for <pgsql-hackers@lists.postgresql.org>;
 Sun, 16 Jun 2019 19:26:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=vIv3kfr3pv8EiEouxpLQ9q0FgOY24tNzlGp6jGrzp14=;
        b=vZN1YYHgQ3/jtl0z1koB5hhPch/4qZD8WV+XcwkA+ABnnnGM6io6ia3e0k5PMNSGjD
         TNvu3gsRfx/V+JIUtXaa0fqvKsTU2lx4GKwh0ObJr+yBERdaYJEQFrDsJIKW5GTZZM+O
         AdtmsCaAD3dvNCELdK4y36GgQPNCOyiEt69ghfFdlDPqQfEjERVR6FWG0s8PKWpF9k91
         AQ/ntRvRoEFP+y2H1lC9pP3CSpXm2DlZgKc7mFvXu//dgaQQLO2QEKyZd49CKbSLHTHe
         G3CqvGTAoyW06k/7kneBmhvAD0DTzANUFHCN1+xk5aFY1k2irRBdXKBDNIzQ0/m39WpM
         Eh0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=vIv3kfr3pv8EiEouxpLQ9q0FgOY24tNzlGp6jGrzp14=;
        b=lSqD2ku0FbF5kgBc518tf1HEv7rTQ7mea1OlRNfjSHvrG2Fqampm0e7m5YzmGI1qi1
         UJN3kE5IYGDoBlAHtm3o1jKNoCqAMjAPLcWBGqLXnLqsYk+BBxmHsraG91PSJ4KnxxcH
         SqVL3scQ8Fxyq+vxmyIqq5P/oZVX4NBgTTDrCw3M1oWYQon5oZtEEZv9JwcNLsjb9GD/
         ZodMpLb/+AMVJ5QkhI0gnIkYRE+kTH9FiVusMEkvZF3vYXWpV0m1H3lf3rDOLexSiKPa
         7ySWRVf+jostnXSDKUrxbSvxoWl1eLEJ1ywz5Rz2WkS1XQ0HPWtFJCIb6vgV919x61aY
         XqJA==
X-Gm-Message-State: APjAAAUncjeeY9hT7MejG1DeRXXMo3ddQhQXBermJitAhQEkq6e/TMpJ
	ULONr/eSRN/6c2hlTYXyvqNtvQ==
X-Google-Smtp-Source: 
 APXvYqz9C6lW5TZenQyG2tv9vaB79UwXeUeuTE5uomls+jJnn/jqGYJnHH4WR7dlzOk1DBVeQks0IA==
X-Received: by 2002:a0c:afac:: with SMTP id
 s41mr19326315qvc.184.1560738358683;
        Sun, 16 Jun 2019 19:25:58 -0700 (PDT)
Received: from nimloth.alvh.no-ip.org ([179.56.48.227])
        by smtp.gmail.com with ESMTPSA id
 s35sm6317360qts.10.2019.06.16.19.25.57
        (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
        Sun, 16 Jun 2019 19:25:58 -0700 (PDT)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 05A78120619; Sun, 16 Jun 2019 22:25:56 -0400 (-04)
Date: Sun, 16 Jun 2019 22:25:55 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Oleksii Kliukin <alexk@hintbits.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock
Message-ID: <20190617022555.GA20544@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190617013211.GB3153@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2019-Jun-17, Michael Paquier wrote:

> On Sun, Jun 16, 2019 at 09:10:13PM -0400, Tom Lane wrote:
> > Yeah, let's do that.  I don't want to risk shipping broken code.
> > We can try again for the next updates.
> 
> Could you revert asap please then?

Done.

I initially thought to keep the test in place, but then realized it
might be unstable, so I removed that too.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services