Date: Mon, 17 Jun 2019 14:40:53 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>,
	Tom Lane <tgl@sss.pgh.pa.us>, Christoph Berg <myon@debian.org>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release
 2019a.)
Message-ID: <20190617184053.GI2480@tamriel.snowman.net>
References: <24452.1560285699@sss.pgh.pa.us>
 <20190614095546.GA15107@msg.df7cb.de>
 <26948.1560517875@sss.pgh.pa.us>
 <87ef3w3u8a.fsf@news-spur.riddles.org.uk>
 <7114.1560539536@sss.pgh.pa.us>
 <875zp74zpf.fsf@news-spur.riddles.org.uk>
 <871rzv4yes.fsf@news-spur.riddles.org.uk>
 <20190617173943.z3ttxqenbcwrlag4@alap3.anarazel.de>
 <20190617183458.GG2480@tamriel.snowman.net>
 <20190617183828.hj7ci362zbxd4nax@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NBo+v+z9rqUBJl3+"
Content-Disposition: inline
In-Reply-To: <20190617183828.hj7ci362zbxd4nax@alap3.anarazel.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--NBo+v+z9rqUBJl3+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Andres Freund (andres@anarazel.de) wrote:
> On 2019-06-17 14:34:58 -0400, Stephen Frost wrote:
> > * Andres Freund (andres@anarazel.de) wrote:
> > > On 2019-06-14 23:14:09 +0100, Andrew Gierth wrote:
> > > > So here is my current proposed fix.
> > >=20
> > > Before pushing a commit that's controversial - and this clearly seems=
 to
> > > somewhat be - it'd be good to give others a heads up that you intend =
to
> > > do so, so they can object. Rather than just pushing less than 24h lat=
er,
> > > without a warning.
> >=20
> > Seems like that would have meant a potentially very late commit to avoid
> > having a broken (for some value of broken anyway) point release (either
> > with new code, or with reverting the timezone changes previously
> > committed), which isn't great either.
>=20
> > In general, I agree with you, and we should try to give everyone time to
> > discuss when something is controversial, but this seems like it was at
> > least a bit of a tough call.
>=20
> Hm? All I'm saying is that Andrew's email should have included something
> to the effect of "Due to the upcoming release, I'm intending to push and
> backpatch the attached fix in ~20h".

Ah, ok, I agree that would have been good to do.  Of course, hindsight
being 20/20 and all that.  Something to keep in mind for the future
though.

Thanks,

Stephen

--NBo+v+z9rqUBJl3+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJdB961AAoJEO1sijiDR2RVYPcP/jWPXPSJn3Urphx0HzFHeGnv
A9Tc/vL35gN7ZIhzkpSpCjte7eOzr9cEAO/8Hs81m+TgYLulbaztIVw6XnMvVENK
Al6MrH5zk/KpjBz3T7kSYo80VMKvUHieItd6XsohILqV1tmEsbBeB2FwsRXQTmPa
rlUWm1tXdttjCt8nUhj1/lApFrNh/IDY168BwsRVmE3z29eiz+VSvvcs2z7bscBT
UVe32L+h/gn77ux0PSUlRO1Zjg5jE9eGE1fPn4bSBvKdOPT0VQ+U6asWwgl8PIIX
pMxF13jIClDsA+QsZ/CoJM37m3Rr4o8ZOvccKjCL6vUfRLXZ41fQ4GfNpnOwyClN
sZAcZJCoFY7aoclie13V7ov17XULW/3y4v+HHJXBg3mPX5+FDZSWDvMe7wG/OvDV
XwwcgaaTzIuV0xOlk2IgjUD0ds9UoaQlo7ARFOtqWSapkkVqm8R2FELB1UI92tp+
gZ6O8mlc43a1qqwW8LCrgJACqaIlWZnoY+BgPesFEI9jbzD4Yd6f3+XHuGH7nB/S
n4QuqAIm2ovBVv6kX7JL8QMNK0RnsUIlg6fuRDh+oRHZoDk4LyCGnLyKU50RNSwc
Z/y2M1HAbY9kYSYNibnQajrsCICFL255mbxueD2i+TAvCZaNUj7USRwORS9HtE77
8A7EMyPhr8QggR6CLbKP
=2Ydi
-----END PGP SIGNATURE-----

--NBo+v+z9rqUBJl3+--