Date: Thu, 20 Jun 2019 15:24:12 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Christoph Berg <myon@debian.org>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release
 2019a.)
Message-ID: <20190620192412.GG2480@tamriel.snowman.net>
References: <20190620161400.6wtuybv64ihnfy6d@alap3.anarazel.de>
 <20190620172838.GA21945@alvherre.pgsql>
 <CA+TgmobK3TVoxNJ0vCwvLcAjjaLvMLFWcbEpWA042bT9VdVWfQ@mail.gmail.com>
 <20190620182406.GD2480@tamriel.snowman.net>
 <87y31wytdl.fsf@news-spur.riddles.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QrUjNlhiyonfhBQa"
Content-Disposition: inline
In-Reply-To: <87y31wytdl.fsf@news-spur.riddles.org.uk>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--QrUjNlhiyonfhBQa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Andrew Gierth (andrew@tao11.riddles.org.uk) wrote:
> >>>>> "Stephen" =3D=3D Stephen Frost <sfrost@snowman.net> writes:
>=20
>  Stephen> In the situation that started this discussion, a change had
>  Stephen> already been made and it was only later realized that it
>  Stephen> caused a regression.
>=20
> Just to keep the facts straight:
>=20
> The regression was introduced by importing tzdb 2019a (in late April)

Ah, thanks, I had misunderstood when that was committed then.

> into the previous round of point releases; the change in UTC behaviour
> was not mentioned in the commit and presumably didn't show up on
> anyone's radar until there were field complaints (which didn't reach our
> mailing lists until Jun 4 as far as I know).

Ok.

> Tom's "fix" of backpatching 23bd3cec6 (which happened on Friday 14th)
> addressed only a subset of cases, as far as I know working only on Linux
> (the historical convention has always been for /etc/localtime to be a
> copy of a zonefile, not a symlink to one). I only decided to write (and
> if need be commit) my own followup fix after confirming that the bug was
> unfixed in a default FreeBSD install when set to UTC, and there was a
> good chance that a number of other less-popular platforms were affected
> too.
>=20
>  Stephen> Piling on to that, the regression was entwined with other
>  Stephen> important changes that we wanted to include in the release.
>=20
> I'm not sure what you're referring to here?

I was referring to the fact that the regression was introduced by a,
presumably important, tzdb update (2019a, as mentioned above).  At
least, I made the assumption that the commit of the import of 2019a had
more than just the change that introduced the regression, but I'm happy
to admit I'm no where near as close to the code here as you/Tom here.

Thanks,

Stephen

--QrUjNlhiyonfhBQa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJdC91cAAoJEO1sijiDR2RVeLQP/04h8v7WyXJeB55LyzQ3StlU
gQBnhEN3GMIOO7/3fqmK+RAN/9UTbGJiuskqAE9YLvwERnVSbvVUQelF63UMhBp7
2DWeWSrDB52oSZon4ZPX55BTiweUhitco8TPeSHHdT7Qqc8zQ+inlv2dMgqTHunZ
ovbbOAL3qLjTOZ/nR7AaGtE7TOaAeO8J1dW7WMaollEl+/GfpXXyp1Yzq5rlfRsN
6vSq9zXtHwQrEFHhc6gYTNm+OJZMHN+6EDFQRLujDsXOqKhe9zPTSoNTV8kSDFcU
gHtFYzY9VhyPxrhYJOeiTIjn73h3MUVC4LEy6g0HgYszYRgM2NGlTmZ2/u9eX21y
HPUumXTJM6l+9C65tw0XtArAruLofqkmMzosE6s/9QLIvrqEc3f3EkvLsOPO7Sxg
7iHNPtS7eBrKNGRPk8WoSMFHWypeeoCIcgEV7ji/8AoPwhEHnjl23M24Qt9zGma9
u7h8Twv8xocL/DiiJHuSQ/uVSyx158GXkGOdkKaKOymYeo0vxMQKHe9i/GcXrGEL
lXqvV2Fv668TvnHfxkFivDKG1Yz9Gkxk6GCpElfTG0Sz36mo0DQW9igDZcOGgV0n
UMveAf4GcJrtIVuxOzkKT9L4N5VuTmR75dgz53dtZ2fQdW2qrnlRkGRHtrh3cV4k
akZY/QMoXLPaVXrX6/nv
=C9RI
-----END PGP SIGNATURE-----

--QrUjNlhiyonfhBQa--