Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hqQC1-0008T2-Kc for pgsql-committers@arkaria.postgresql.org; Wed, 24 Jul 2019 22:57:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hqQBz-0001Po-G3 for pgsql-committers@arkaria.postgresql.org; Wed, 24 Jul 2019 22:57:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hqQBx-0001Pd-M9 for pgsql-committers@lists.postgresql.org; Wed, 24 Jul 2019 22:57:03 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hqQBt-00088I-DD for pgsql-committers@lists.postgresql.org; Wed, 24 Jul 2019 22:57:01 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2368421B24; Wed, 24 Jul 2019 18:56:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 24 Jul 2019 18:56:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=uhzgMdx0s9HPGRG8cxS4OV3LcYx RREw193PxnpEWYdI=; b=cKu4UATIInhpe8ab8vYOV08aG4iIqWcKM8lHdaXZIl+ PKNXLJU2xccnwvkY8DS2o0U0zL0yyM9WeaHQN6iOSMv8gWmVTLowZtCHxObKjQq9 XC6eZHqzOVgtCLyVVltuRpWRptf/+BNWm2VWaricxDSXbxYGPv65Rqnt6ziPvPmu B9i/Xs1G5FH8okD2Ye0PFte4qrL+/Ckm/GdxxoChHPSODhzRKp2pLtKbSxevGQ3v +8kOctIU2oXD4SM3MzMNMmXdk7zGLmDZX6oiljxM1AwPD+QHId5MAhnwkanUQCtv KAz9+i2rxSihGZrazr0ra32BUgqPCXPTw2jf2V72D7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uhzgMd x0s9HPGRG8cxS4OV3LcYxRREw193PxnpEWYdI=; b=jKnAGNBI4oVwRP3k42FRAr +aDB0ngL2GI9m8C30ZzTJ4rLrocKupqnPIAwzbf8M0Ll/UiOndXWMuq/wk671ZMH 7g3Bd9W7nZdbQmnn8ARTGw4iwoC2x9uieiDlaBI7ApeXMC561jYJ3kY4cd39J7iH HOsVsVm7sq82PdV8v7pFbnrLoNJrW6P+V7sBWjUsqhYbRe1bNwLb659kzlqClBf+ TeCapSkfo2KZ/gnKINEmG3m3TWF/507qCR2Y6qWXCdj6wZkSsk0rxr37AaudBYNj /z0zIuCcanQ3UDqhgTlqcWI/oCa1QvRizurxejWyaLr15q7BIuGrDHPVzlgtohQA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrkedugdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecukfhppeduuddurddutddvrddukedtrddukeehnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 066DE380076; Wed, 24 Jul 2019 18:56:53 -0400 (EDT) Date: Thu, 25 Jul 2019 07:56:51 +0900 From: Michael Paquier To: Andrew Dunstan Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Improve stability of TAP test for synchronous replication Message-ID: <20190724225651.GA6000@paquier.xyz> References: <16da29fa-d504-1380-7095-40de586dc038@2ndQuadrant.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <16da29fa-d504-1380-7095-40de586dc038@2ndQuadrant.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 24, 2019 at 02:17:14PM -0400, Andrew Dunstan wrote: > This broke our perl coding rules: >=20 > ./src/test/recovery/t/007_sync_rep.pl: Subroutine > "start_standby_and_wait" does not end with "return" at line 33, > column 1. See page 197 of PBP. (Severity: 5)=20 Fixed, thanks. Indeed I can see that pgperlcritic complains here, and I have added a call in my pre-commit scripts for the future. -- Michael --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl044jIACgkQnvQgOdby QH06pg//c80Bt312696bU5xaAub6AUgzbAuFvpoXATEE8JSbwejdnW1zUc8N8yNW eOFNTwxjWjQLxZCU65L5DcYRXlIiVk/J7k+8hb+B4nS+TSRbN18jSVlnTjSzVcpk SJeCMtRA/CS5dpbSkbV7lzs+DiS72BrlsdaRjkxNGsNVaGuPdiPLBnTasjZxerik Ma02DhIhePhMNJ3OaBWPa1BP+zvnGaij7i5B9GV+J82dnKJeDBAdBlut1MdCRDUn kWXyMZ2KaDwdKUsDYan6T94Xjd0dpIqtGH9qOsGwb5uswUksIrc0C7DePn5srTil N9VqFGpZ0il+Qgtl88A+W/M4SzLrme+SxgabRws5pN8iDnACMRsuE3hjXEUiv7lI Hb4ruhMFQKTQWkiEuIG82D+GiLLlo24l9dycHKBjW05SXkh+kW7Dyt2rUrl6h285 m3z2siNWxVUBPkDDaQXXmiavC3Tc4QFYQ9tZetKKP5TtkfbBzyVvQuV/JmzMH5K/ OLG8PnLkhMrRS+khMQm8F4yntl1Mxh9Yz/IPkhZMtA9oIXQ73s6ZkwtM+S71Ah1o vXcDXGH9Uwnwxrfgy1QG+5jEBuMQjEPpN+q/HrMzMe6agTRauToXs4T7N+AQV+bh LkK7yVE9QMeUAwNmDKNz05sOdXom4NMkv9iFlwZNLvsT1oqoQPQ= =ozbT -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--