Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iBLdV-0008A0-ET for pgsql-committers@arkaria.postgresql.org; Fri, 20 Sep 2019 16:19:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iBLdU-0000Jz-3x for pgsql-committers@arkaria.postgresql.org; Fri, 20 Sep 2019 16:19:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iBLdT-0000Js-T9 for pgsql-committers@lists.postgresql.org; Fri, 20 Sep 2019 16:19:55 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iBLdQ-0007yI-95 for pgsql-committers@lists.postgresql.org; Fri, 20 Sep 2019 16:19:55 +0000 Received: by mail-qt1-x843.google.com with SMTP id u22so9243290qtq.13 for ; Fri, 20 Sep 2019 09:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=/n3Y/qZlB1MXQU2YGq/4QdlBU+R6wyRWjdfvV+pEgqo=; b=ZKmcWyu1Nz2ULcevvkX2jmy15ytKr/ZiFVGEzVID5oQsevyFfl8tADA+aYwMi+qDfO KexqiiNScKMBAmH5RANkMSDFrgCu8dch32a6VDlCabdA8zq2lo5l1kVhHRQbce0JkI1T SN1qwmPVAgd7p6/lMNlDX1hkcYkATIMYKC1leCscZ1y6QrRwGQv9fwFOiaD8/ePN5NY+ RP5WfAjdv8BedGrETSKvsLA7AeyOjRbIAXkjpC2Cb+2t+hk4wp6vVm4GHE6CpLdph+uI 3qiUNOAAmVxXQKqVYVqey6oRO7r/c2hz9XS/T0S+SCz6myKrBQ9u1tOP+aqZdo3iSHgJ KqjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=/n3Y/qZlB1MXQU2YGq/4QdlBU+R6wyRWjdfvV+pEgqo=; b=PC9cXDSo7lOKsv4zxfuV6kEcZm9v9NilXxm/uf3v6q9CFQNjoFOYgfDPFECbFaytEO +FZnTks+G1Nr+09YAXXeKW0IN1bxg2FK4wCXC8EulMADwcfJ0J17eUHIB99TdYR1bv2G FPcOp0byjB4SJvcAL+ujDXNyV0PtSxaHHNMAMbRhNIiNo+px7J/OPbn7N+mFOHYEAZCh jtf6PBbhHor1plmvlDG34fMaHFr3Gc3Q767cN1mWSSolEkKVxJO9+zofWghSgXqaUJMo yFg0PZjBDfsJmmUtOF3EG6v3aaWceTSlLlNKSu3ANoJ4iMId17tMoGd6bH5asdREHeN1 jqsw== X-Gm-Message-State: APjAAAVNrAOzFbTAzcFA1f2nFqiv4xDXPmhi/GUUlp44G4KKTj+DoQQz uYfLJTqx0D/pvFikMSEyYy9XOw== X-Google-Smtp-Source: APXvYqxxNDI74sn1UVZyARWTM6JhwCHvDNxY+AXrH4zRV60A5Mv0qPCi0STGWHGyinvsMuu7g3WU+w== X-Received: by 2002:ac8:6c44:: with SMTP id z4mr4195121qtu.229.1568996388935; Fri, 20 Sep 2019 09:19:48 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([179.56.51.60]) by smtp.gmail.com with ESMTPSA id 187sm1275767qki.80.2019.09.20.09.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 09:19:47 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 4ADCD1207A3; Fri, 20 Sep 2019 13:19:45 -0300 (-03) Date: Fri, 20 Sep 2019 13:19:45 -0300 From: Alvaro Herrera To: Amit Langote Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL Message-ID: <20190920161945.GA17912@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Sep-17, Amit Langote wrote: Hi > I noticed that the progress of REINDEX INDEX index_name is no longer > shown; REINDEX TABLE table_name is fine. Maybe you missed updating > ReindexIndex() to pass the option to report progress, like this: That's right, I broke that case, and your patch fixes it. Pushed, thanks. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services