Date: Tue, 1 Oct 2019 11:04:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Davis <pgsql@j-davis.com>, Jeff Davis <jdavis@postgresql.org>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add libpq parameter 'channel_binding'.
Message-ID: <20191001020430.GD2781@paquier.xyz>
References: <E1iCVWg-00057D-8U@gemulon.postgresql.org>
 <24857.1569775891@sss.pgh.pa.us>
 <20190929234733.GA2888@paquier.xyz>
 <20190930064539.GK2888@paquier.xyz>
 <20190930070826.GM2888@paquier.xyz>
 <11a5c3b483f1c0140f9fc5cf863d8ac61a28e60a.camel@j-davis.com>
 <19002.1569867629@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="LTeJQqWS0MN7I/qa"
Content-Disposition: inline
In-Reply-To: <19002.1569867629@sss.pgh.pa.us>
Precedence: bulk


--LTeJQqWS0MN7I/qa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 30, 2019 at 02:20:29PM -0400, Tom Lane wrote:
> Jeff Davis <pgsql@j-davis.com> writes:
>> For 2-3, shouldn't we error at an earlier stage? The user of the client
>> has requested something impossible to satisfy.
>=20
> Can't get excited about that.  It'd require duplicating this code
> somewhere else, which is a maintenance issue.  And the case of building
> with obsolete OpenSSL ought to be fairly infrequent and getting more so
> as time goes on, so I'm not really eager to expend lots of work on it.

Neither am I, and there is one extra reason on top of what Tom has
mentioned: there is still value in warning the client if a rogue
server sends SCRAM-SHA-256-PLUS without SSL even if channel_binding is
required.

I have double-checked the patch and done more tests (server publishing
SCRAM-SHA-256-PLUS with various libpq clients).  I have included the
full description of the behavior in the commit log, and applied it.
--
Michael

--LTeJQqWS0MN7I/qa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2StC4ACgkQnvQgOdby
QH1/QQ/+MHqRfDVuDUkiX8O5dG+v0H4I1LMzhL2VLKCMRyUu2r7DMxk99d0Y9wMJ
ejmji3vcIQoiEtVEieQ3/RjjJvOLplnpfVPjDJp/rgKkz/sCK0T+pyWNhXSiqZ0X
9rHvOm5zOthfYM7AAQRNwvu14GS48qpAoH5Fk5uKqskEjx0/LNpz84pGTyqL0iDM
9cER5aH7v+i3O0fQk6mjxjyIcPlofZtY1QNFYrYmZZfDH6ZhvoxHzvBBQwG+4XFo
xfzmyG8f75i0Glhr5WXKl9ek00TYLoFo1eUMxpBBGhvESw8bv0zvd1FQaleHqbfm
yBZkc+522BRVMfLErB2P+HsQAFNPARVYNiWUFpWbonwuBQ6UvmTZAY/FQ/JPibwe
+Gaj0kmOe/mlwSRM/nklnm1hF6JhEGOZEBJsZq/2j+TMNDFSxXBe2/qwd9bNebR7
oJ3GafV5Za3Q4HkQkfYZNsM9vVZtru4+eqJ2qu9/ZNVeStYz2o2im0zdNoiBOVp6
XhkoqIu2eG1/MBNsA1H0yfP2PrnMxS8iI6+D0BNmI4x2kj4REMQe9H9fVGJMwmeU
cjscr+6V6p3pShbaF/P8L+jsCROz70kdoISresEnynQUMtcERaktUZvc33cUo4X9
Q5gzl6J3Qf8pge7d/SC8SDthcer1zCJheurNRNalHYzx3EcSrPs=
=RrRl
-----END PGP SIGNATURE-----

--LTeJQqWS0MN7I/qa--