Date: Tue, 1 Oct 2019 14:22:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
Message-ID: <20191001052245.GH2781@paquier.xyz>
References: <E1iF8dy-0000fc-9S@gemulon.postgresql.org>
 <20191001045246.GF2781@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qVyHzDF4yf4A8jkR"
Content-Disposition: inline
In-Reply-To: <20191001045246.GF2781@paquier.xyz>
Precedence: bulk


--qVyHzDF4yf4A8jkR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 01, 2019 at 01:52:46PM +0900, Michael Paquier wrote:
> This indicates that it is possible to reach GetCurrentCommandId() for
> a parallel worker in this context.  It is possible to get rid of the
> problem by enforcing the following in the tests so as we have no
> parallel plans:
> SET max_parallel_workers =3D 0;
> SET max_parallel_workers_per_gather =3D 0;
> Or just use SetConfigOption as per the attached which would be a bit
> cleaner, and both could be used as a temporary solution to cool down
> the buildfarm but that does not feel completely right to me in the
> long term.
>=20
> Any thoughts?

Actually, it makes little sense to allow parallel workers to log their
activity in the module.  So if there are no objections, I would like
to fix that by checking after IsParallelWorker() in the hooks of the
module.
--
Michael

--qVyHzDF4yf4A8jkR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2S4qUACgkQnvQgOdby
QH30RA//VG19x/NZ02GJgiZJz7EbdkHSjF+pApVCahWkozcshi7X6hGktRcZYoc0
MSFmE090MfTb1b357WM2ERJmcy8KLSnyv2MVdrkPuB5/W4L23KV3l/iFAz52v4wv
NFntLgv0zMIIydPbCTKHFmhF1GMj73aqJ67njijvHAXmIn3N75RFq44PaMGlAl1p
6rJTS2NXb9ri2oJ0OZ7IkAQUpCaPdMuY4HWgR0GGc/dTEQUScjQIsWUJCCZjOJq2
py9+sUMzdpQKeV0Ifr+qST7EGuBufQtPhu9UwNYDbpeFvHsrkJ1deIW2nHaX7vGv
gsH7P33gjNqlViN/VGedAFvpYug85ZW11Nl8Atycb61nxIvItvlb99KPaWzjH9Dy
2Mzl/jJtouua87N5SOXegBszn1+I4IjyXZvsavxFk1UaHTAbPXd9M/lqiIlR5Qem
f0RfZasN1LWxfw/ztVzYKkUqIKy/p+XHAfMtl1m/WUDriMnZNCaDSG3YtGwBbOPR
higoOvVSN4A/9DZmNp/hOQVDb5CN3KOdNSqUczlcmtYGj3S/Omz0zGW1LGEunctz
xx69FFcjv2Ud5ktfkWNThzqhQO8Mcjh4mNDl5w0SEEZpgvJ5aJIa5yRJZjPcdBhp
yEs63hazLJv0REp7nykh9bkEEIHFso8c/BwkwY9DWjtbgK5n6/Q=
=mZbf
-----END PGP SIGNATURE-----

--qVyHzDF4yf4A8jkR--