Date: Tue, 1 Oct 2019 23:28:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: pgsql: Add hooks for session start and session end, take two
Message-ID: <20191001142816.GA25272@paquier.xyz>
References: <E1iF8dy-0000fc-9S@gemulon.postgresql.org>
 <20191001045246.GF2781@paquier.xyz>
 <20191001052245.GH2781@paquier.xyz>
 <20191001071320.GJ2781@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx"
Content-Disposition: inline
In-Reply-To: <20191001071320.GJ2781@paquier.xyz>
Precedence: bulk


--dDRMvlgZJXvWKvBx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 01, 2019 at 04:13:20PM +0900, Michael Paquier wrote:
> On Tue, Oct 01, 2019 at 02:22:45PM +0900, Michael Paquier wrote:
> > Actually, it makes little sense to allow parallel workers to log their
> > activity in the module.  So if there are no objections, I would like
> > to fix that by checking after IsParallelWorker() in the hooks of the
> > module.
>=20
> Fixed with 002962dc, and crake has just turned back to green.

Even with that, there is still one failure with Msys and fairywren:
ALTER DATABASE
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D running regression test queries =
       =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
test test_session_hooks           ... FAILED (test process exited with
exit code 2)      493 ms
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D shutting down postmaster        =
       =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 1 of 1 tests failed.
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

The differences that caused some tests to fail can be viewed in the
file
"C:/tools/msys64/home/Administrator/bf/root/HEAD/pgsql.build/src/test/modul=
es/test_session_hooks/regression.diffs".
A copy of the test summary that you see above is saved in the file
"C:/tools/msys64/home/Administrator/bf/root/HEAD/pgsql.build/src/test/modul=
es/test_session_hooks/regression.out".

Unfortunately it is a bit hard to grab what the problem actually is.
Andrew, could it be possible to get more information from this animal?
--
Michael

--dDRMvlgZJXvWKvBx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2TYoAACgkQnvQgOdby
QH3X5Q/+Ogg3jvgboeoFB3PRtaDoM+hJrFIaezpfoHCtxAv08RNGKvLjZSWxYyKw
sqfG/ml7EXfbJSUW/Aw8LZcEuDWAFYgmIxYODHs6F79MoCEXtY2C8hU/rL/jRY2I
EPF5t6limeC+2PM9ZtI5991QT1fOdX4L385Mz0y1NR2WDDJdmwtESjYnFc+Pj/aP
Vrun+CEzlmvCkFXja7neW2tNX/il0ZE+OOPeXlTK7DwYtunZEWQxuK5mdiDhK8f6
/lmCqz/rwidXPDOblgFe1bIiXxWVLIt6znBASUYrZ2sjH2GqJoknG9wkRbgA3w5a
pbBqa2uUFKHXFJnIOMc1bvettxzam/Tw5d4tePFIlk/07X7XgBRVrPci7/a6Yxdp
GjgDUcF8+6fEacSIHZ9oqLw15WADo/nslVC1x2HjZ9jPAw133TC7FjPm7/cZG7m9
2ZRhfWVe6C5OkVfmJZVf1TMd/eneUq4KviEj5TMUOlqHIpAXfCfLsJlN3cSYTVaz
UoqC4lfG6GRFpIt48J8kszsOFK+Rnk1v1qmccgQ7L0cErzr8E6aP4zO6Y0FYZ29a
Ez1r1Dly7LpZCyIpfQfeXDZtDDXR7wK49JtKmg2FubiGdoxfVzsTzcnJ63/JEK6B
Y2mPaLZJX35HOjorm1qfasNnjB56Ifir4hfz2y41xwazaLl/Do4=
=L5x8
-----END PGP SIGNATURE-----

--dDRMvlgZJXvWKvBx--