Date: Wed, 2 Oct 2019 09:25:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
Message-ID: <20191002002558.GB3130@paquier.xyz>
References: <E1iF8dy-0000fc-9S@gemulon.postgresql.org>
 <20191001045246.GF2781@paquier.xyz>
 <18722.1569906636@sss.pgh.pa.us>
 <20191001052543.GI2781@paquier.xyz>
 <20191002000228.i2vcd4maxy3nl3vp@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+nBD6E3TurpgldQp"
Content-Disposition: inline
In-Reply-To: <20191002000228.i2vcd4maxy3nl3vp@alap3.anarazel.de>
Precedence: bulk


--+nBD6E3TurpgldQp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Oct 01, 2019 at 05:02:28PM -0700, Andres Freund wrote:
> The reason for that is simply that at that point llvmjit.c's own
> shutdown hook has already shutdown parts of the JIT subsystem (which
> needs to flush profiling information to disk, for profiling to be
> useful).

Hmm.  I missed the actual point.  The current location for the session
end hook has been chosen because we are sure that any transaction has
been aborted properly, and we'd still be limited with a hook in
proc_exit_prepare() because of that same argument.  I am just going to
revert the patch.
--
Michael

--+nBD6E3TurpgldQp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2T7pYACgkQnvQgOdby
QH3n9A//cz/q8KPvGdZBKdFBVBKYCdoszn/jOIPkCp6hGRx1KHV2Cf7mYDBTKdQl
QEnrJF0DFlZQ9flqDO8LQDaArdcTQtQ9vsbyptP0K8jbYdtSaBJ5t1WkO0gTXKyb
HFjNQGBW/nDfofUxu9Srs5Ogwah5n2k2HCOKM9yPrCqxfeaF1CBwxYnk9sw2GzC9
BQ2gp98EMCh7lAexvuzmsCOtqkW5nqo4FHApf9wLgH2QKWHiVAKTEFXtMOr93ycp
Q8S10L0PwwaQLrLce2sgrsYUGX2AstCFcAvrxNJ9b3Udts5ZCjpFp1UNCyBMh8+e
UXNbrjwgGVJBhAcyZojSfJ3IqC/JX4ySeh4FVepIc2P7s1SXBIyooZ+RKn8ckuss
aYl6OatZanvNKIz94afCBCSZq9XHuWe7umgVfu0rYUs8y6XKR00IMTzFtqN6SuJX
xt7fo7FYomq3mBCKluLqGKeTKpJHIgJFP6sO5yqPnhif9zwYiINtswmrdY5nnjsE
9JZHQ06eZb7DOQDXAs/ohVSmZPXlEkqXRheB647TBKBbD6cGuvB19AGtbfs0dS21
Mmd5O7O60ugW1L1SwZzPSjo6GZj1k7zDI+UOzX/Z+5D2N4rc2DsEESWD6g8yeWae
fwqt7pqsYDm69YbYV4XiYOAIyh61e15pa8/4HLErgSn34SI5eaU=
=lxOO
-----END PGP SIGNATURE-----

--+nBD6E3TurpgldQp--