Date: Wed, 2 Oct 2019 10:08:39 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@gmail.com>, Andres Freund <andres@anarazel.de>,
	Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
Message-ID: <20191002130839.GA7050@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191002051424.GC3130@paquier.xyz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2019-Oct-02, Michael Paquier wrote:

> On Wed, Oct 02, 2019 at 01:27:50PM +0900, Fujii Masao wrote:
> > If only session end hook is problematic, you will commit session start
> > hook again?
> 
> Sure, it would be possible to cut the apple in half here.  Now my
> understanding was that both hooks were a set.  What do people think?

I think that having just session start is still useful, even if I
encourage you to get session end covered, because yes they do form a set
:-)  I don't think it's completely *impossible* to get session end to
work, only it needs to be run prior to any subsystem shutdown (I haven't
actually looked at the code, mind).  Of course, it'll need to be clear
that it might not run in certain cases.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services