Date: Wed, 2 Oct 2019 10:07:40 -0700
From: Andres Freund <andres@anarazel.de>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
Message-ID: <20191002170740.ldzmr23b5zfgxnxk@alap3.anarazel.de>
References: <E1iF8dy-0000fc-9S@gemulon.postgresql.org>
 <20191001045246.GF2781@paquier.xyz>
 <18722.1569906636@sss.pgh.pa.us>
 <20191001052543.GI2781@paquier.xyz>
 <20191002000228.i2vcd4maxy3nl3vp@alap3.anarazel.de>
 <20191002002558.GB3130@paquier.xyz>
 <CAHGQGwGy7Dg95YXppzRqiX-q=y5mePKSS8YjX13CMHe9h0WbWQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAHGQGwGy7Dg95YXppzRqiX-q=y5mePKSS8YjX13CMHe9h0WbWQ@mail.gmail.com>
Precedence: bulk

Hi,

On 2019-10-02 13:27:50 +0900, Fujii Masao wrote:
> On Wed, Oct 2, 2019 at 9:26 AM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Tue, Oct 01, 2019 at 05:02:28PM -0700, Andres Freund wrote:
> > > The reason for that is simply that at that point llvmjit.c's own
> > > shutdown hook has already shutdown parts of the JIT subsystem (which
> > > needs to flush profiling information to disk, for profiling to be
> > > useful).
> >
> > Hmm.  I missed the actual point.  The current location for the session
> > end hook has been chosen because we are sure that any transaction has
> > been aborted properly, and we'd still be limited with a hook in
> > proc_exit_prepare() because of that same argument.  I am just going to
> > revert the patch.
> 
> If only session end hook is problematic, you will commit session start
> hook again?

My impression is that these patches first need considerably more actual
design and code review. This wasn't a subtle issue or anything.

Greetings,

Andres Freund