Date: Wed, 9 Oct 2019 09:37:34 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Christoph Berg <myon@debian.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list.
Message-ID: <20191009133734.GW6962@tamriel.snowman.net>
References: <E1g5vmT-0003K1-6S@gemulon.postgresql.org>
 <20191004095630.GA29119@msg.df7cb.de>
 <9333.1570566305@sss.pgh.pa.us>
 <20191009073354.GB30556@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kyDGfcSsqT5jcshG"
Content-Disposition: inline
In-Reply-To: <20191009073354.GB30556@msg.df7cb.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--kyDGfcSsqT5jcshG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Christoph Berg (myon@debian.org) wrote:
> Re: Tom Lane 2019-10-08 <9333.1570566305@sss.pgh.pa.us>
> > Having said all that, if we conclude we can't break compatibility
> > with this legacy code quite yet, I'd be inclined to put a
> > separate, clearly-marked-as-legacy-code version of pqsignal()
> > back into libpq, using the pre-9.3 SA_RESTART semantics.
>=20
> That would be nice.
>=20
> > But I'd like some pretty well-defined sunset time for that,
> > because it'd just be trouble waiting to happen.  When are
> > you going to remove 9.2 psql?
>=20
> Note that this change caused breakage on the wiki.postgresql.org
> infrastructure which still had an old 9.2 psql running. It wasn't
> Debian's fault that it had not been upgraded yet.
>=20
> But I refuse to buy the argument that I'm doing something wrong here.
> Shared libraries have SONAMEs to prevent *exactly* this kind of
> breakage. If you are removing symbols, bump the SONAME.

Yes, this is absolutely the right answer, we shouldn't be removing
symbols without an SONAME bump.  If we don't want to bump the SONAME,
then don't remove the symbol.  This is utterly basic proper library
maintenance and it isn't appropriate to argue that it's about "well,
your old apps shouldn't exist" because it's blatently our fault for not
bumping the SONAME, no matter how old the apps are.

Thanks,

Stephen

--kyDGfcSsqT5jcshG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJdneKeAAoJEO1sijiDR2RVbQwQAKyECbNdgxahz/FjASV9Dptu
1SnUL1Q8r2g0wqYusNtao+qXJgurMtwKSmMfXEwg6HJm/SLJhZdbwfGo4o1tEP2K
dVwvlZPEG0DFEvPYrAt1AA7u3dEwyr7CcW72cS0ljb03RVJJVCUIF5dZwcBJ+HMV
gOiZ7AcsT8H3MZj8u0sQUuTjAjwFb16RdrYC0wVcLqaEYfhJg6nm8/qcb2rUVbxq
4HJh5h3wry5dXfXPXH8M5krCH+R0ilaHaCCQgVGUPLCkHj4gLV6dWPjtvJlGYZ/m
/YYnHYVripiCfV9EWVx+YQcYElZ3ozcwkBLIgc7Sa3QXAy54tumdjap+UQw3TZWs
sTPA9bofLQXqwfoh+oTrYBlbtoK6aRsm4/ScymGIxKoJyM190SJllu6D82svGoQs
XzOOCI2J8lajhUd0AYcXZ86m2kUXUr3indCo5WyBukRogPYrrKbDXQIwD8Ifs2ji
uRFq+w3EgGM0jXrAC55NUR6miQqxP/LkScVTc+Ath59NFO8Ed40MyxvZic3i4voK
ffYcdVijtZXJXY+/rgL/ecEYZ55FmghA/I3yAC/SXW3Xsml43B8r/uQI4x+hp5F5
4GTRbKRcoFq3mJS8GzzaQuuUZb0SOLXp/IUAdg4aza785l/YMYnGWAZCISxdiI37
dAO4xEP/ntYQGLk2K+US
=cdkG
-----END PGP SIGNATURE-----

--kyDGfcSsqT5jcshG--