Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iIPZK-0002qO-G1 for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Oct 2019 03:56:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iIPZI-0003pr-2e for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Oct 2019 03:56:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iIPZG-0003pP-6c for pgsql-hackers@lists.postgresql.org; Thu, 10 Oct 2019 03:56:47 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iIPZC-0003nx-Kg for pgsql-hackers@postgresql.org; Thu, 10 Oct 2019 03:56:44 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B122221B2C; Wed, 9 Oct 2019 23:56:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 09 Oct 2019 23:56:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=/d5IprOduGXDkFvHLJ0rICL+94b v6aLJEn+P9RdYwCM=; b=Oq4hoSQy00Ka/IwXePya+dP9imod7S1hvXuvtfkg9sY lqtiPnpuAWhNkFZvq6PRPg1ovhY00nqSfZHPNlxnHl8Cm8coJJPjV2CmPAVjAzzE YoAVI3wzO4/YItZCu8viyDGWWw6KIKdu0IURewy8Sk7mnfzbpi2u3xI+Yc4iOIXZ BjR/ftgHVImHemDPt1V79t3CTe6eBiTW+ffvkyei0jyP3rAYtNoepJIFoxSf+aUn /CSgoSnFEO6B4QDUgRrfbZQeWqeAKn8DF2vyfxoqUw9kV1RYm4Z8jE22c7cfSuWh WtVwIBrowuHjOkGeFQf45AKbPxXNQPUN8XalZ8463ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/d5Ipr OduGXDkFvHLJ0rICL+94bv6aLJEn+P9RdYwCM=; b=ttL0aHat/+rNAstpb49Qho hTFMWT91jMv7ABUDFt0/NNO8v1UgaAcEB0MyxJ35BnRvPd0kBpAYZQAs2YJVv6yg cJ69KfL+vH5JBPfiNlskUH2kvDX5SDpQl8lVqW+LYWR47ic+amPGduj7Wq3z7BNT +8F3KnQua6EnJ8udJGKgBMIvBj0FFB08MakSG77XtySmX7Lohjm3jYu0lOkbuz22 udVbI0waHI9DhUw5dg1VMX9IhVkgzN7qR6bzdMz1XE4HQLGNPZHo8vfeC3moI/vJ /PfnFhI7K4li7I3bj0f4eSHkIICWsDR7raeVVDUzVhZ7z5y+SeCGWKgyPJitU5oQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedriedvgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucfk phepudduuddruddtvddrudektddrudekheenucfrrghrrghmpehmrghilhhfrhhomhepmh hitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 609738005C; Wed, 9 Oct 2019 23:56:38 -0400 (EDT) Date: Thu, 10 Oct 2019 12:56:35 +0900 From: Michael Paquier To: Stephen Frost Cc: Christoph Berg , Tom Lane , PostgreSQL Hackers Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list. Message-ID: <20191010035635.GD1852@paquier.xyz> References: <20191004095630.GA29119@msg.df7cb.de> <9333.1570566305@sss.pgh.pa.us> <20191009073354.GB30556@msg.df7cb.de> <20191009133734.GW6962@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IMjqdzrDRly81ofr" Content-Disposition: inline In-Reply-To: <20191009133734.GW6962@tamriel.snowman.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --IMjqdzrDRly81ofr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 09, 2019 at 09:37:34AM -0400, Stephen Frost wrote: > Yes, this is absolutely the right answer, we shouldn't be removing > symbols without an SONAME bump. If we don't want to bump the SONAME, > then don't remove the symbol. This is utterly basic proper library > maintenance and it isn't appropriate to argue that it's about "well, > your old apps shouldn't exist" because it's blatently our fault for not > bumping the SONAME, no matter how old the apps are. +1. If we were to bump the SONAME, more cleanup could be actually done, and I got some pushback not long ago regarding some undocumented APIs in libpq that we still ship for the exact same reasons: https://www.postgresql.org/message-id/7990.1565550764@sss.pgh.pa.us -- Michael --IMjqdzrDRly81ofr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2eq/MACgkQnvQgOdby QH31zhAAhPLImWrw9TIN4cNPpAJRGzo2zzak2y8GiGc+H0oinYAaY7sEgyGTClTL 4/jTj3hwrJmSYrgwuz6dtdpWMDyzyrZxeXm0rsMTbO3OibeAvcUcQXTSuChMqoZ8 uYKpMEpj1sgl9LmWc5+MMdbXb4/upzssXnXeitYJRd7D+l7a1T8rtPzfXCbOX3jJ YtaO07t99NijlsufhF5yivECuW25qiPwhifmhx8EXyn7h3c2slyE5D9RttVj/XHT CHht6bLtDdEPfvzioBVgPRYyOASmyhxeZSL+iNUBZipNMrGzWqF6jJgdrHe+YzyU 5pV3GqKLEybv5hXJY4yz5TmDu1ZzElwXnWg/OcKTiqEJyywVDF+zsYkg/jvsSUgP 4g6FfHfCx5XdZ7dXsWIyo/heBbggcDlfAZH1heuUzS/prY6ZYigAi4OldVOJwPCJ oD15rgTtojflON+rscDTwQDKdLTbljGzUM7UfjbHprxMtrXfbyukI/n9qS3aWdKe SMnyL4hwEXcijdzHBgKvG33UCqZn9egKDDnyZGOM6NmyP4lVCKGTjsdJi8CkJP9m T+e+37mojH7LHsf1HT8C6GdDZ8kUWyzbAqn4kq2fjTU3ekYbORxD8nbj1cnkn5/d I5mk1WnqfDSV+EBzhm9MBaUcMxXQgHUHy35kYel2JZyJYDI0vqw= =8Gqp -----END PGP SIGNATURE----- --IMjqdzrDRly81ofr--