Date: Sun, 13 Oct 2019 19:13:31 +0900
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix dependency handling of column drop with partitioned
 tables
Message-ID: <20191013101331.GC1434@paquier.xyz>
References: <E1iJZdr-0005DB-GE@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="oTHb8nViIGeoXxdp"
Content-Disposition: inline
In-Reply-To: <E1iJZdr-0005DB-GE@gemulon.postgresql.org>
Precedence: bulk


--oTHb8nViIGeoXxdp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 13, 2019 at 08:54:19AM +0000, Michael Paquier wrote:
> Fix dependency handling of column drop with partitioned tables
>=20
> When dropping a column on a partitioned table which has one or more
> partitioned indexes, the operation was failing as dependencies with
> partitioned indexes using the column dropped were not getting removed in
> a way consistent with the columns involved across all the relations part
> of an inheritance tree.
>=20
> This commit refactors the code executing column drop so as all the
> columns from an inheritance tree to remove are gathered first, and
> dropped all at the end.  This way, we let the dependency machinery sort
> out by itself the deletion of all the columns with the partitioned
> indexes across a partition tree.

rhinoceros is unhappy with this one in the sepgsql tests as this has
moved a cascading drop notice when droping a column:
 ALTER TABLE regtest_table DROP COLUMN y;
 LOG:  SELinux: allowed { drop }
 scontext=3Dunconfined_u:unconfined_r:sepgsql_regtest_superuser_t:s0
 tcontext=3Dunconfined_u:object_r:sepgsql_table_t:s0 tclass=3Ddb_column
 name=3D"regtest_schema.regtest_table.y"
 ALTER TABLE regtest_ptable DROP COLUMN q CASCADE;
+NOTICE:  drop cascades to view regtest_pview
 LOG:  SELinux: allowed { drop }
 scontext=3Dunconfined_u:unconfined_r:sepgsql_regtest_superuser_t:s0
 tcontext=3Dunconfined_u:object_r:sepgsql_table_t:s0 tclass=3Ddb_column
 name=3D"regtest_schema.regtest_ptable_ones.q"
 LOG:  SELinux: allowed { drop }
 scontext=3Dunconfined_u:unconfined_r:sepgsql_regtest_superuser_t:s0
 tcontext=3Dunconfined_u:object_r:sepgsql_table_t:s0 tclass=3Ddb_column
 name=3D"regtest_schema.regtest_ptable_tens.q"
-NOTICE:  drop cascades to view regtest_pview

It seems to me that it would be fine to just update the output to
the newly-expected behavior.  Any opinions?
--
Michael

--oTHb8nViIGeoXxdp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2i+MsACgkQnvQgOdby
QH3OFxAAinBBI1B5udFxN3LWgPupj1S2zCPTHnezRfAL3uLGVXdGbb81HcDrbKNv
z1rwfek+lkY42hT9jb0e6MMcLcVHeM8tQGzlmDu9Jtb5lDQOM+Dss/QvmFmiB/uT
yPCYrvonq80QOq8d3G9quSXbQXkiThzIc/td1GQg1B1Jmizjbu07vPPew8lVGPsi
3V+xpGkEOoQew7YWCt/scRJ8dP85wiuGHzeT9t8SNEdpirVsU2OzpUd38TTW4iFA
Labn+JWE2gRUn8IqVZF+mRmpKxWBhbYUka56fFOtkDmdSws2ISZqAOM46DX17K2A
zCsIpuRWQNwO69x6f2B2XODZPSaGb4TCTeiCXAaKBpdpA29QO1InmVNr0gGQzhHC
38jbhn5UxoTsUVKnx5YO24W/KbCkOzaAZwhRQHAHamsrlzzFoywoVesCUfRPjtM0
BshhUBOR2d8EnWZfLdJMx3G/tlA9MDuMv1hjJt8O+NK+IvbPubE/U4JXC+kFBNJq
4JOoeaVj/3b2+CGeVs89azcvBtBrp2JmhoNdPnef9VYOSiVXCQM3qdaGFi++hv6d
GqmyQxZ2KpqxMms3DupzTQmcensa+moxaW4CvuJ7tG+5+t03j4YZ0N7/Z+UfahwQ
EvWIeY5Suyt5XDC37MGnGoBCaWVpHxx5BcUwUFtJOZ5Eb0OeQLk=
=Zk0r
-----END PGP SIGNATURE-----

--oTHb8nViIGeoXxdp--