Date: Fri, 25 Oct 2019 12:17:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make the order of the header file includes consistent in
 non-bac
Message-ID: <20191025031702.GD8671@paquier.xyz>
References: <E1iNpHW-000855-1u@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Xm/fll+QQv+hsKip"
Content-Disposition: inline
In-Reply-To: <E1iNpHW-000855-1u@gemulon.postgresql.org>
Precedence: bulk


--Xm/fll+QQv+hsKip
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Amit,

On Fri, Oct 25, 2019 at 02:24:50AM +0000, Amit Kapila wrote:
> Make the order of the header file includes consistent in non-backend modu=
les.
>=20
> Similar to commit 7e735035f2, this commit makes the order of header file
> inclusion consistent for non-backend modules.
>=20
> In passing, fix the case where we were using angle brackets (<>) for the
> local module includes instead of quotes ("").

locust has just reported a build failure here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dlocust&dt=3D2019-=
10-25%2002%3A58%3A55

And the cause is visibly this portion of the commit:
--- a/src/interfaces/ecpg/pgtypeslib/dt_common.c
+++ b/src/interfaces/ecpg/pgtypeslib/dt_common.c
@@ -7,9 +7,9 @@
 #include <math.h>

 #include "common/string.h"
-#include "pgtypeslib_extern.h"
 #include "dt.h"
 #include "pgtypes_timestamp.h"
+#include "pgtypeslib_extern.h"  =20
--
Michael

--Xm/fll+QQv+hsKip
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2yaS4ACgkQnvQgOdby
QH3Ibg//Y/cFEnJLOmyH5bqVYDGFOLNd+bxS6a2pMQARbfOYhfGc16p16o+TNV/W
k7gKPZjZihFttYGrb+DDi16mf8Qepma9rheDXlQ8ywWBm4E7G6iWX6UZTqednjta
8hFv5jn6Gx/JgVoyubmblbthe1wgoaGgdVKnBvb2c/Al2t0RKHUHps853oV/Q9CJ
SJ7Mk5I4VDsGQoZDC8FRiK5Vp4szrPsQLXHWIURsFwfonvof5ljigiSYRnVRD2nk
BSgoQ2jGfMEmfTN0VLBN1lRFElh7Mgf79aPiAJjmSbv4/1niI05VZJ2DUihaC5F4
AaRsHK/a9Y5fu6+PhEzCWO1M+wry9dH0n1zwExB42ojSpaTdhC85h8VyjCghyyy9
RfIvqLBzvwmL7SOB7HvRvjNRvBO5r3530pPJsWPG2zq8CpOzZUGnBzYAVHpPWHq9
kQ0tXkWwOhOe9qEewSGBxKqd9xMmwe6vCL2tvL84p+fn57GKEGAjwDHhJHZuQEKx
+Ghm2h/shmmbb95XM9LWnMBSXx2Z2NCTwlKSTPM4sQHbYHN/N62EAEvhXmSmybaF
IOB65U1V8Zj+6bkeHbAq/Y7shZ4oMs18OryajUhucLlVCQaOlfsQY/a1M0hvKoLY
d9KvtI9UZKP3C26zGzJpPo5FaTstlwazZnmh+KAVYQfmzcVzlF0=
=AmnB
-----END PGP SIGNATURE-----

--Xm/fll+QQv+hsKip--