Date: Fri, 25 Oct 2019 15:17:09 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make the order of the header file includes consistent in
 non-bac
Message-ID: <20191025061709.GE8671@paquier.xyz>
References: <E1iNpHW-000855-1u@gemulon.postgresql.org>
 <20191025031702.GD8671@paquier.xyz>
 <CAA4eK1JfDfKvjSYOoQFHu=sSzaqdDTR+JZkZqJkvVnueFJPG5g@mail.gmail.com>
 <CAA4eK1+Rvft5SgGnBfGdNCVMspDMiXEo=i7Ue2e9Pm0bbOC3jA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mR8QP4gmHujQHb1c"
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1+Rvft5SgGnBfGdNCVMspDMiXEo=i7Ue2e9Pm0bbOC3jA@mail.gmail.com>
Precedence: bulk


--mR8QP4gmHujQHb1c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 25, 2019 at 09:32:29AM +0530, Amit Kapila wrote:
> One possible reason could be that pgtypeslib_extern.h has define like bel=
ow:
> #ifndef bool
> #define bool char
> #endif /* ndef bool */

Possible.  I have not looked closely.

> It is possible that all the functions that have bool has a parameter
> in dt_common.c treat it as 'char' where as the declaration of same
> functions in dt.h doesn't consider bool as char because now
> pgtypeslib_extern.h is included after dt.h.  It seems that the
> platforms where it failed doesn't have bool defined.  What do you
> think?  I think we can revert the change in that file.
>=20
> BTW, prairiedog is also show similar failure and both seems to have
> similar OS except for versions.

Remembering the recent efforts that went behind stdbool.h (see
9a95a77), I think that we should be able to cleanup this header more.
Reverting partially the change looks better for now to put that the
buildfarm back to green.
--
Michael

--mR8QP4gmHujQHb1c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl2yk2UACgkQnvQgOdby
QH1i7w/8DAo3cBEi0X+KbVEeLpauhqlnDdZIVgi0downDIubgM/Kod4umiEY1GY2
VPaI+ucGj10xymCJaxlIrjEH/v9g9gFoRsRXQv23fSSJM91HKguBJeGCJ2HJroCj
2zymLaqAdFGtjTWkx3chxRiAW7CFE3DlBVlRArbI5ydyhxJblExhk2JioHGEokti
2jfhDI/xugyXp3vOoigcLRm8L5r1nQw3crmT5G6divD8Y1coy/dyrajV3OLUOUJG
djd4R8WeTXLzVbMHGtqT0LEsG/dlwiZN8KmV6HkGqd6wJ0OdIhpkr1Cx3pFbrsjz
QVYLkZQ+jD1yHin4zIlXjyUKgydaFa+aJqbCdYKRupxAO7tkRdi1vTV9Vs3z/8ws
uDkKJ66BXPRsndJ2dQJwUkTzkrLcFs55n8j8tKIdmWr0omOx6G4NX7Nm5bXPl+gN
XdZRK7McGEw1QJMr8S2EGfTNMLgGXSmd1WzRRhrxVwfEAQv3wLemk+b6UiJKbfIe
Sqmt8ybgEci5Fz3lBIUkxo1yE1/iASm5rOiMfoTtw2XDuD11a4kTmIUuh07GOytw
Zpc24PojJVivI4/3JNc2ltL7TdwkGHYoCxDReOsq6lCPgzpcbsUcZyhB5jr4acWy
c9/E3AizxdwBgriRMCH/VlT7mzBS1Gf6A1k6SzrXNJ6RwKFlpwI=
=ql4C
-----END PGP SIGNATURE-----

--mR8QP4gmHujQHb1c--