Date: Mon, 2 Dec 2019 12:18:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
Message-ID: <20191202031814.GD1696@paquier.xyz>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
 <13656.1575041267@sss.pgh.pa.us>
 <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
 <15399.1575043746@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9l24NVCWtSuIVIod"
Content-Disposition: inline
In-Reply-To: <15399.1575043746@sss.pgh.pa.us>
Precedence: bulk


--9l24NVCWtSuIVIod
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 29, 2019 at 11:09:06AM -0500, Tom Lane wrote:
> I agree that this is somewhat pointless in the case of an "unsafe" test.
> But using a different name isn't going to invalidate the test case,
> so there's not really a reason to not follow the convention.  And
> trying to have an exception for unsafe_tests seems like a lot more
> trouble than it'd be worth.

Yeah, I agree that it would be just more simple to make the unsafe
test adopt the convention and be done with it.  Could you fix it
please?  longfin and mantid (as well as anybody running the unsafe
tests by themselves) are complaining for three days now.
--
Michael

--9l24NVCWtSuIVIod
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3kgnYACgkQnvQgOdby
QH320Q/+IlUD9bdtpHgYB3CXRacgtHLn7j3eIM/hixjyamgjTiYN+Pru6XICmpeI
q7OC33stU6bojPdo6KkpWdNrKdNVs7xswPzQQdF7sUTxps9dH4qYRcXu5rRiuKSi
nGORCiex86+sMvdfzOhrT1btNXOEqdiofN4Gv0fnYW25ejeJoUAp2yqkY7nYUIku
svhPd09uiWSMU1awePegARomcY6XFHx9pFGqTT7jBZDKCYkH12SPHsplOw6Pz/Cg
sDxkhJKpharmwamgvY1t+sipWUD4hNS1IJ6EeF6I0cCKpRvrsRnT8P+5SezjT+V2
JWQTCHZ4puk0ODj9TyfDsRkwSIQ4s/A8zJnZHMiHb2hqHtJ2H+0mJMHflOMcIQXr
uICnT78jqiETqsT6EaaqiWOD4gXjaYBCVWNO3FimM6FTI8bSrw+szX7oFk219ifN
8F4jD5DRBnDF8S1XLGJECqWhCQuFYoDiUyzk2ahkVnTdwl0GO+B9/A2U5ly/fEzU
OBeDC4nIYOeHcBVl/tmeHst5kiHHMOoLEgyy3iECFcTZWgecQy86NqmMgIX0tKdE
zhPumGkd1oCporC7UCOnUKjPDgu1KpnbYU/9zLJ4rCBMGxCLBdF6+xjLDGruaevW
KnXxjmZwAvHvkISvbtablfNdIUucCtbew+w4itImHKY/a0CBRbE=
=Gpux
-----END PGP SIGNATURE-----

--9l24NVCWtSuIVIod--