Date: Tue, 3 Dec 2019 13:12:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
Message-ID: <20191203041247.GD1634@paquier.xyz>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
 <13656.1575041267@sss.pgh.pa.us>
 <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
 <15399.1575043746@sss.pgh.pa.us>
 <1e7bb9a1-1104-907d-da62-857408d271ef@2ndquadrant.com>
 <29779.1575299500@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mJm6k4Vb/yFcL9ZU"
Content-Disposition: inline
In-Reply-To: <29779.1575299500@sss.pgh.pa.us>
Precedence: bulk


--mJm6k4Vb/yFcL9ZU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 02, 2019 at 10:11:40AM -0500, Tom Lane wrote:
> One way would be to provide a variant expected-file, but that's not going
> to be fun for future maintenance of the test script.  Another simple
> answer is to crank up client_min_messages for this one test to hide the
> WARNING, but you could conjure scenarios where that misses something
> important.  (Of course, not running the test at all would also miss
> any such issue.)

Alternate output files should be IMO avoided if we can, so if I were
to choose sneaking a SET client_min_messages would be fine, but only
for the second create tablespace..
--
Michael

--mJm6k4Vb/yFcL9ZU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3l4L8ACgkQnvQgOdby
QH2BxBAAjlA8KoP4ZhSdTTfYCybz5RPeTKA8A5LBj7uz8kSKOHp61H1nHJmFcX7L
Hlkc/J2SeBpoo5OIKuxFw/ghZ9RcueI+cG3jpgT7St/0heEZunxm1A17PyRKvpkz
aKOLkhrhI5NWuU4bZMtZxx60nbaflGCa4e2W8ojiLiFXd+yd1miYn+ciqHYDwzRX
oyJQnC7zobZc4hNcwaBdG18WMOhZ5DE1xJmzyqrgEe9+IP0zZiGH5GofyIkRObuK
It2hO4tNWdemvFLShvtVLdrkRdvE/EOxW/c1hD4FUOObFAjZrhb3S5xeN+xHM8oU
gxjkLXEW+H3Gy2SkP7HCeIKHiyH5lIP9Tqimm4Q3iPSmMkj3kICKRPMgsYGThfsy
8HqxN1wFFOQLxEsWElQAxNr1Rk43d5eLc6LnhDIHsneaqX6WMyaORfdlz2XwZWki
RaSsW8M/xRTUU2Z4Td2685k6LAwKgzaBPqRpU65JaicOwCsB/nhg7mwjseDpKvyx
TTJgOEu0iMAgJMjfLsTXaZSVAfOWPY6Raq22UaRoOGaFPUc/7gBWYxszA3ZFA6RX
xXiu1H2k4T/gxbNWSlAsbun259P1z1TfkK0Ha8XOboodZcNkvuP/CVu8XrUqoNQg
A9+qFs94WKFnIcqBGpF18TJSukA1uhGIvxuaBcDwJ1QaEj8LY1w=
=kUg5
-----END PGP SIGNATURE-----

--mJm6k4Vb/yFcL9ZU--