Date: Thu, 12 Dec 2019 13:47:20 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Emit parameter values during query bind/execute errors
Message-ID: <20191212164720.GA27169@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3562.1576161217@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2019-Dec-12, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Emit parameter values during query bind/execute errors
> 
> (Some of?) the Windows buildfarm critters don't like the test
> case you added.  I speculate that the test pattern is neglecting
> to allow for Windows-style newlines.

Hmm, the affected ones (jacana and fairywren only AFAICS) seem to be
gcc-based, which presumably work differently than the msvc-based in how
newlines are interpreted in the test script.  I pushed an attempted
blind fix.

I *hope* that those two are not the only Windows ones running the
pgbench tap test!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services