Date: Mon, 6 Jan 2020 20:13:03 +0100
From: Christoph Berg <myon@debian.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
	Amit Kapila <amit.kapila16@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Message-ID: <20200106191303.GA3975@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	Amit Kapila <amit.kapila16@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <E1in6ft-0004zR-6l@gemulon.postgresql.org>
 <20200103110128.GA28967@msg.df7cb.de>
 <13708.1578059577@sss.pgh.pa.us>
 <25771.1578249042@sss.pgh.pa.us>
 <20200106105608.GB18560@msg.df7cb.de>
 <3764.1578323719@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3764.1578323719@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Re: Tom Lane 2020-01-06 <3764.1578323719@sss.pgh.pa.us>
> > Does not work on Ubuntu bionic, xenial. (Others not tested.)
> 
> Hmm ... do we care?  The test output seems to show that xenial's
> 3.1-20150325-1ubuntu2 libedit is completely broken.  Maybe there's
> a way to work around that, but it's not clear to me that that'd
> be a useful expenditure of time.  You're not really going to be
> building PG13 for that release are you?

xenial (16.04) is a LTS release with support until 2021-04, and the
current plan was to support it. I now realize that's semi-close to the
13 release date, but so far we have tried to really support all
PG-Distro combinations.

I could probably arrange for that test to be disabled when building
for xenial, but it'd be nice if there were a configure switch or
environment variable for it so we don't have to invent it.

> > Ubuntu bionic fails elsewhere [ apparently in 006_logical_decoding.pl ]
> 
> Hmm.  Not related to this thread then.  But if that's reproducible,

It has been failing with the same output since Jan 2, 2020, noon.

> somebody should have a look.  Maybe related to
> 
> https://www.postgresql.org/message-id/CAA4eK1LMDx6vK8Kdw8WUeW1MjToN2xVffL2kvtHvZg17%3DY6QQg%40mail.gmail.com

The only git change in that build was d207038053837 "Fix running out
of file descriptors for spill files."

Christoph