Date: Mon, 6 Jan 2020 19:15:23 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>,
	pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Update copyrights for 2020
Message-ID: <20200106221523.GA416@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+hUKGKDLjA0qGoVr01TU3+GoHhE40vz7j0+KGjVZF3noLJy0Q@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Jan-07, Thomas Munro wrote:

> On Fri, Jan 3, 2020 at 7:41 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > On 2020-Jan-01, Bruce Momjian wrote:
> > > Update copyrights for 2020
> > > src/test/ssl/ssl/client-der.key                       | Bin 1191 -> 1192 bytes
> > > src/test/ssl/ssl/client-encrypted-der.key             | Bin 1191 -> 1192 bytes
> >
> > I'm not clear I understand why these two files changed.  Did you have to
> > regenerate them?
> 
> It looks like Bruce's shell script to advance the hands of time added
> a newline to these binary files.  It didn't seem to break anything,
> though.

Well, the script does nothing more than run "sed" on the file.  It's
weird that it found matches in those files.  Another observation is that
the script has skip logic for certain binary files; it should skip these
files too, surely.

(I re-ran the script in the commit prior to Bruce's to verify, and
indeed it reproduces the changes to those files.  Weird.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services