Date: Thu, 20 Feb 2020 12:02:40 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clean up some code, comments and docs referring to
 Windows 2000
Message-ID: <20200220030240.GG2288@paquier.xyz>
References: <E1j4GrA-0006wL-WE@gemulon.postgresql.org>
 <9781.1582146114@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="B8ONY/mu/bqBak9m"
Content-Disposition: inline
In-Reply-To: <9781.1582146114@sss.pgh.pa.us>
Precedence: bulk


--B8ONY/mu/bqBak9m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 19, 2020 at 04:01:54PM -0500, Tom Lane wrote:
> Surely this patch broke the error case in haveNativeWindowsIPv6routines()?
> That is, in the admittedly unlikely case that LoadLibraryA("ws2_32")
> succeeds but GetProcAddress(hLibrary, "getaddrinfo") doesn't, what you
> now have will do FreeLibrary(hLibrary) and then proceed to use the
> now-dangling hLibrary pointer anyway.

You are right, thanks!  This block has no meaning anymore, so
removed.

For the note, it looks that we could get completely rid of
src/port/getaddrinfo.c once we drop support for XP as IPv6 support is
enabled by default on Vista and Windows 7.  For XP, one needs to
install an extra module manually.  Do you think that there are other
platforms using our port implementation for getaddrinfo() except
Windows?  That's not material for today, obviously.
--
Michael

--B8ONY/mu/bqBak9m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5N9tAACgkQnvQgOdby
QH1nAg//W8bnbsFgD3RvK5h6L/QbeCSgVOkxI9ywimGCpDPBJ8PvtM5fi8mpjnRL
i0ymhGfrD+Hj7FV+Iwo6LD2QOZgqxw3zCUjMu5Pk1cFjfO4OMzK96i4Hpc5CPSjg
ujt/rsakuB8VM+cM1gVTphp+GmOpXmodHV2F5OuC9Of+nVGVPV+sDLkoxOwABC5B
iqastVYUNGWz4X/Ig9WYVaWuToIN7oxUoX3uOgGQzOx7w9clQEuq0S5/bI/3bfZO
DHtHCNFv69iSSlh8UQqKm0mhpnNxvEX5P5BcGtVFZyFZxe2BeZLV/Sxn2lyCY2uy
Bd0whRkCjAM75PCpcR3pPS1Rp9izYf1kK4bk6TN370XmNG3v20XZEuA/LXhj8+Lp
+RuE0AEFDoPbtoZzFrPHu50eIlL70GwcwYEnAaamLmnnRo+pQgBsjiUA+cXH5M9U
UC21Y6aUnH/bRMLr3/zFtZgAcVXlkvO11lcqzpoZgz7l4aPnSaQHuRhuFHKQBruO
FwEjAIeUC2ZfMGxO8A3r3UqgHfJW2CnNmw6wQiWuIMD2Ud48zISkVadQUMtoOCXM
STTAQIFZ1QbANtsnGzgzQ4/8zDz+2eSsyr2Kwt5x2bd0IKx3MROpV5dXk5TTwBcb
GQI0r2L3SlbdtD2jyuYFA99y1gQT/vLdUs7cu38si+E3D92QTCQ=
=DeIs
-----END PGP SIGNATURE-----

--B8ONY/mu/bqBak9m--