Date: Fri, 6 Mar 2020 08:30:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Message-ID: <20200305233014.GA2501@paquier.xyz>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
 <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q"
Content-Disposition: inline
In-Reply-To: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
Precedence: bulk


--Q68bSM7Ycu6FN28Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 05, 2020 at 12:51:50PM -0500, David Steele wrote:
> Looks like you changed 65535 -> 65536 before commit.  I checked the original
> patch and it has 65535.

That's my fault, thanks.  I have been playing with the surroundings
while looking at your patch.

> Bit of a bummer that this passed make check-world, but the pgBackRest tests
> definitely did not like it.

Is that because you have a copy of this routine in your code?
--
Michael

--Q68bSM7Ycu6FN28Q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5hi4YACgkQnvQgOdby
QH3XHQ/8C8zuw/PxFWwdLmSx456oT2pLf7WWqI+Aq0ysB7O7OZZgQIMfsbYIQ3PY
xep7SCMfX9d/4Rtc9EzuQTWYROSr9IntNiBanq6lwYycaIZGxfIhkOeBUCDTdj4E
kZ2YL/6x0uX3neBFwYU8iKVzXMAhPMqhLVt6lagdSTbKGgu3K/vogeEJHp1JJjXg
fL2dVp2z3wFjmbXQhO1M3xz3TxGuTYZfuP9y6PXNPiTkHb7MJSOQ6g2sQmC+IBDd
tzNQSOKM5P6LmIEQ44QD9l6ciOo8fPCwCACuedSqcwGw3FDLqdmFNot8KDMLa3u3
1XegICIZ8lqLSvvMsRs6oumd3I3FG4XN/eZ3kBFKxwYZl7ChKep6qVlRtCBu61v0
HOUVHIjN1VOsetkSqkzbdpf/IWkiEvkBH62izl1s5/0OuZADEqU96yyUbsr0WPMD
MsqwOacrC+0X0DV4Y/ObVDSrpGjFkyxDoIuyfL622LRtC6vOtj2z9o0W15KtHk7N
8JwcHZCF+jfrJr6DKqIR1qMTebxhvlwBbPKwC9ivozXtk2I5IaMbUjiZaoCZgIXH
WnLNer6gX/Mk0BRrn9h59JHJ63GRBubhLoZL8oHmkf0FLJsGeLPaWbz4p3gHxHfi
mVwLRaEyN7CdoWenMw231WeNMTUAc87mUONTpft7VHabjrlnfPs=
=cSo6
-----END PGP SIGNATURE-----

--Q68bSM7Ycu6FN28Q--