Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jA10I-0006fb-DV for pgsql-committers@arkaria.postgresql.org; Fri, 06 Mar 2020 00:38:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jA10H-0001hc-1S for pgsql-committers@arkaria.postgresql.org; Fri, 06 Mar 2020 00:38:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jA10F-0001hV-IA for pgsql-committers@lists.postgresql.org; Fri, 06 Mar 2020 00:38:12 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jA10B-0005oa-7e for pgsql-committers@lists.postgresql.org; Fri, 06 Mar 2020 00:38:11 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D93C5221C2; Thu, 5 Mar 2020 19:38:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 05 Mar 2020 19:38:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=E9FRQMfheZOPW+E34HO22x4hrZ5 3iQzXgHREteIKNcE=; b=ceXyMz35UYysrfj7o0vnzemobECj3fcwjTam3ob+LCN hutGr4bkkLMbrlq+t9Ep1KwYIaVN7QC1yCb0Rr+5qT3GoqBXZaPUVWuNfReQTmRQ hbTFkuKW2+6djFr5MNES+9j+fp8Zc2GLQidaN4jZS8KhQEO/HKJUntyozye9M9E5 Fi/UMIToeHB0pIf2v3ITLEl4Dr6uLHE7tKfN6B7MUuSSIMmY4Va8xvjvF86dvvbj pVWydPypV8C7wvJ5TI+rMILQHwzFAxkSEYzwfyB2/USH1cB6VUlZZWwDwmGmTh9w MuDFzwp/HyaGGv7ZYHTHe1jkgtZXCsi/7A0JNYlv3vw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=E9FRQM fheZOPW+E34HO22x4hrZ53iQzXgHREteIKNcE=; b=RHnZhXl3Y4gF145WxHmgw5 GgU+VoTicjxAZjpkv/hPRWIN7oYHi5a8u4BK3C0x29qUyoA8zeGQWZQ4oEToDctz NIq0hCY+kTop/69tQH0m3Na4cEyg9vIBjD+mP1X8Wc+D/eeelmcqO3ZvCRt+bzI4 9685m5mUva/WD528D4jV5a5R3yKWoqz+4NZl+407RPpdjaGSj3RYyHYm7KB3zf33 p6TfFeQasYXBLY2jLl18vElOFM0c/ro9H/zenqJBCeLZRq8W7RmX33jLFQ+rptBh JJJX/TUqQCz2IPiGDay9RCQqYVEmg3DDS7hn4o6DvRu0zfws06dhoecAp8CTP8Kw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudduuddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppedu uddurddutddvrddukedtrddukeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id B89BE3061363; Thu, 5 Mar 2020 19:38:02 -0500 (EST) Date: Fri, 6 Mar 2020 09:37:59 +0900 From: Michael Paquier To: David Steele Cc: Magnus Hagander , pgsql-committers Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h Message-ID: <20200306003759.GA52814@paquier.xyz> References: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net> <20200305233014.GA2501@paquier.xyz> <7916219a-96c6-4298-cb36-c97c6bd3930c@pgmasters.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline In-Reply-To: <7916219a-96c6-4298-cb36-c97c6bd3930c@pgmasters.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 05, 2020 at 07:32:59PM -0500, David Steele wrote: > FWIW, we use static values in our unit tests (which are written in C), th= en > test against packaged versions of Postgres for integration tests. >=20 > When I saw the commit I pulled it in so I could remove instructions for t= he > manual step to add the cast. So in this case the issue was apparent real= ly > quickly. Normally we only pull in new code from PostgreSQL once a year. >=20 > We think our unit tests against static values may have endianess issues b= ut > we have not verified that one way or the other. Here's what they look li= ke: >=20 > https://github.com/pgbackrest/pgbackrest/blob/e55443c890181ea63a350275447= 885331c8254e4/test/src/module/postgres/interfaceTest.c#L182 By doing so, the tests still fail if the page size is something else than 8k, no? -- Michael --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5hm2cACgkQnvQgOdby QH0OBg//VBnuzZJp98NvBBA05kV81znjUz/6GIC8pvD+A7JIFVAIBSXvZUvTca1/ ZJwxCrRk07IwpCnNezgpQIim0TmOMk4+BSvv2idF/b+Av4Zq471kITjM/9epHMzq WIWpIUfZK6iy4orQYyPrSwtLs4bPUcU0LdU99qof9BLKFhqy9iBgg3XXSih55Apg 7JQZm4iYjbyptrAyrAkkcOou//JImReTI5W8vxqXEzRVKVzjGeIwYEarR8SGgc4O +ETj+37HegiQthUamaIIwN3GjcMmYg6eoPk9deCgRrTOcK3dXjQ90QwYEb2rUBgH q4oX4Xj8kf3GoaTA44uJdUZRJ532na1EYS8X16pMibuIsqL3g8LqaOoDa/uaN2MQ GhpbmeMVSnyte0I5Y04VCC+CcLebymaMUUd7uoukluiAqIpRC/8MfsmHsdJ8FgXU A9tNW3NwiOPWG9uEHSZfb5y2tODPYrcgpued8NPhp1JH12D1xBB4fNNOg2JBPdpd Itm5xVka2VVg7mb7ht5REOpjvRrfe/xBi6PMMNHiLpFE5uTc9o/NVDJQbw7i7M8x HtXk0mfyFbx1KdtVRBKPWuKhqydH726ghjYd2eII1O0oIF59ymIFVEdAs2Lc9a5D NSUsR3sia4oAePIPhKEA+FMjZcZwp+hCHhxoDEnzl7Y0e9egM+Y= =ep8R -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l--