Date: Fri, 6 Mar 2020 10:10:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Magnus Hagander <magnus@hagander.net>,
	pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Message-ID: <20200306011006.GC52814@paquier.xyz>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
 <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
 <20200305233014.GA2501@paquier.xyz>
 <CABUevEzoWeR_q-JztqacmATBvVMUL9rtOcpM5RACubKcmhmk3Q@mail.gmail.com>
 <20200306004826.GB52814@paquier.xyz>
 <e19fa62e-f140-306a-aa6b-fb55ccb3b9c1@pgmasters.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kvUQC+jR9YzypDnK"
Content-Disposition: inline
In-Reply-To: <e19fa62e-f140-306a-aa6b-fb55ccb3b9c1@pgmasters.net>
Precedence: bulk


--kvUQC+jR9YzypDnK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 05, 2020 at 07:58:50PM -0500, David Steele wrote:
> Yeah, keeping BLKSZ a constant is pretty important for performance. That's
> one of the main reasons that we only support the default.

Doing something is not complicated, now how would people like to do
it?  Here are the options I can think of:
1) A TAP test, which bypasses the tests if the page size is not 8k.
2) A test for src/test/regress/, with a method similar to what we do
for collate.sql for the compilations without ICU.

In both cases mentioned here, we would need a SQL function to handle
the work.
--
Michael

--kvUQC+jR9YzypDnK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5hou4ACgkQnvQgOdby
QH10nQ/7BcEyCdqgbvsyNbOZDfwtHItmGsrFTkiESSRP3zZ1ptolyfSr7vUjk7s/
Wg+fB5KP38sHq97nj0FeJDDZR9fcQbK2S6gYfBrHg6ZIZo89K4DctOYhRISjqbC2
arG+LYUFPujC6E393a9YiEjFIxW4cPmgkGElpg1lPRbG9BAbvqfOe+htM+t4AzlM
C/6Y2fC6ysGqWieCerJRDjR8aseI1/i0Lqek7uNEIRjbYYkF7bB17UhPyredtLbn
1LTmz3/RLXEGezJtrkPvYZ5lDzl/DpG3dj9tca/L6vq2nrGl7HcPa8OjJNpj+CSv
ur+qg2fnU4/6UE4KOxTlywT3SfbYEYHTWHFE91TJBhDaGQCyUPYTdajq+kzY1eui
orUy8KQRZA5kYgWjLZzdPvY0d4uapFwzPdT7Kyuyc0Ktygya2c7iaweDjT+iudWk
gHTmqQ1LihpVhwKH4UkwyIc4jJBDmWKSMbc6BlbL3n7Dtqg4lOC63Xmf2upY/Gvm
pVoioruKHdFgEIBVCrQG13LYF7WIY85vIPlPul656kpnRLSafIAnTYfeKcMTYLLt
z63crJsXmgfrcLsWaSGwzjITaxqgJDF5zlzZ1+q8tGVjnd6VVLPfMpRZnrl5FbWW
d/GQX2JfkZxyS/BMGigLT3yOB85ZqbeHmgpwWgQVut5VFbkPkhU=
=X23R
-----END PGP SIGNATURE-----

--kvUQC+jR9YzypDnK--