Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1jAIT2-0006Ib-5p
	for pgsql-committers@arkaria.postgresql.org; Fri, 06 Mar 2020 19:17:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1jAIT1-0000Hm-0J
	for pgsql-committers@arkaria.postgresql.org; Fri, 06 Mar 2020 19:17:03 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <andres@anarazel.de>)
	id 1jAIT0-0000Hf-P6
	for pgsql-committers@lists.postgresql.org; Fri, 06 Mar 2020 19:17:02 +0000
Received: from out5-smtp.messagingengine.com ([66.111.4.29])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1jAISy-0006Di-DW
	for pgsql-committers@lists.postgresql.org; Fri, 06 Mar 2020 19:17:02 +0000
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
	by mailout.nyi.internal (Postfix) with ESMTP id DCA96223D1;
	Fri,  6 Mar 2020 14:16:58 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
  by compute3.internal (MEProxy); Fri, 06 Mar 2020 14:16:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=fm1; bh=fJVrGuMIMacj//Xg4pyhvkY7aWg
	PYMAongVqq6Yke50=; b=OH6SqHg6COqYvnQkHeLvc403N8hyRA1jytDZZaYPFxg
	ehrGdthVIT79t6Uz3gvu1Ln3NUbRhWAPtfXLqX0UGEoZ7oRqqTkmmLq0LlREKnT9
	Fb52+WnN7Qwx3eCz3jzQI9NyB1vrEM2W8F0FcAAvBcAEAsSbxojQp5iM/SvkwzpN
	mJF+jPLlRxb+9uP8bGLwb+FaYzMQqfXjPsKYdjgOnD8EBScLH4XjE5YG44o7/iR9
	OFGdi7u0sYppDuz8vcAvZXJxvn7wPSBIU+EKYaxC0PD94IGt8SZ2MSX0Cf0c41Mz
	Bt4Re1zLjSmnBM05rG+tNIkyObJ1OJVa+B/mlSUMBjQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fJVrGu
	MIMacj//Xg4pyhvkY7aWgPYMAongVqq6Yke50=; b=HENxMoHsLkxlFAGjUOK8pl
	STRbARkioDENxcsIQmdf1NmQyvEjn7swI96Gpfp50BXPIm7pZlLd82zVioQxHHbe
	9Ao2LFWZLST7z8VnhuRC4zaqhJFfJb8r61nsWszmSrNEofeuMt6ea6Zy/92DRBbZ
	xucq5heyZrsQId8EVtKzoaUnuG0RzX/jI0jwTtVCzehT3AA0J9FM3p+hQpLFd38/
	3d9KKRqkUF5/pZCIsPv6hqZ+VOYTs8SjSC5OclSSiGNvuUd+KP9UePAaekCXF2cv
	xM66OToDP3k1UVnkTD9QLqi0tnAoVpufY6qC6XzVRvEZik6HvzGGdKeT4ZmTOfEQ
	==
X-ME-Sender: <xms:qqFiXgatHm5FTYHTsn4OG_tOUQ4uWM-qc_5RD9deE1vVs1BWmanS8w>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedugedrudduvddguddviecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr
    vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecukfhppe
    dujedvrdehkedrleehrdeigeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep
    mhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg
X-ME-Proxy: <xmx:qqFiXvoEMMmUBV9eiQApRilaGDr_hD-7S2A6N6sYZhiwHGCSO_X-kw>
    <xmx:qqFiXl-nDfJqh9-f2J_8xDz9aa0Bw3V5sJSC80yJLSnkDoCyJhn4hg>
    <xmx:qqFiXu-mwhBZ1IGLhIgAh45qIWG5W3gW6viZyJ7hzbOlD5MfwetsEA>
    <xmx:qqFiXucqzjlgG-Vbl0pd_VDhB_Lq1CPNaf6wVSefUQVOF9HV1Brj7g>
Received: from intern.anarazel.de (unknown [172.58.95.64])
	by mail.messagingengine.com (Postfix) with ESMTPA id 11D283280064;
	Fri,  6 Mar 2020 14:16:58 -0500 (EST)
Date: Fri, 6 Mar 2020 11:16:55 -0800
From: Andres Freund <andres@anarazel.de>
To: David Steele <david@pgmasters.net>
Cc: Michael Paquier <michael@paquier.xyz>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Message-ID: <20200306191655.gm7hjex5c7znmomr@alap3.anarazel.de>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
 <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Hi,

On 2020-03-05 12:51:50 -0500, David Steele wrote:
> On 3/5/20 12:13 AM, Michael Paquier wrote:
> > Avoid -Wconversion warnings when using checksum_impl.h
> > 
> > This does not matter much when compiling Postgres proper as many
> > warnings exist when enabling this compilation flag, but it can be
> > annoying for external modules willing to use both.
> 
> Looks like you changed 65535 -> 65536 before commit.  I checked the original
> patch and it has 65535.

I gotta say, that's something that just shouldn't happen.

Greetings,

Andres Freund