Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJOZi-0007En-C5 for pgsql-committers@arkaria.postgresql.org; Tue, 31 Mar 2020 21:37:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jJOZh-0007zT-7B for pgsql-committers@arkaria.postgresql.org; Tue, 31 Mar 2020 21:37:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJOZh-0007zM-1R for pgsql-committers@lists.postgresql.org; Tue, 31 Mar 2020 21:37:33 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJOZa-00081i-0M for pgsql-committers@lists.postgresql.org; Tue, 31 Mar 2020 21:37:32 +0000 Received: from bruce by momjian.us with local (Exim 4.92) (envelope-from ) id 1jJOZY-0006ak-KD; Tue, 31 Mar 2020 17:37:24 -0400 Date: Tue, 31 Mar 2020 17:37:24 -0400 From: Bruce Momjian To: Tom Lane Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: dummy commit Message-ID: <20200331213724.GG17676@momjian.us> References: <31072.1585690490@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31072.1585690490@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Mar 31, 2020 at 05:34:50PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > dummy commit > > Uh, what? > > Also, I disagree with your change of the wording about savepoint > rollbacks. I agree that "if the savepoint is rolled back to" > is a bit awkward, but I think dropping the "to" is flat wrong. > The savepoint is a point you roll back to, it doesn't itself > disappear when you do so. That's why the SQL syntax is > "ROLLBACK TO savepoint" and not just "ROLLBACK savepoint". OK, I will re-add the "to". -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +