Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMjUI-0002ud-TZ for pgsql-committers@arkaria.postgresql.org; Fri, 10 Apr 2020 02:33:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jMjUG-0006lc-Ca for pgsql-committers@arkaria.postgresql.org; Fri, 10 Apr 2020 02:33:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMjUG-0006lU-5F for pgsql-committers@lists.postgresql.org; Fri, 10 Apr 2020 02:33:44 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jMjU9-0003gN-Ba for pgsql-committers@lists.postgresql.org; Fri, 10 Apr 2020 02:33:43 +0000 Received: by mail-pf1-x441.google.com with SMTP id x3so199925pfp.7 for ; Thu, 09 Apr 2020 19:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:cc:subject:from:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=Ls/VwuyU4BO+1bV+MDNSdcyTHv8Ez1LQ3wxVKdaCZXI=; b=bQze6Wl84EnW4d1/GfVVntrcpqdJXPGZ5PDzqeFKKIas/Ksq1xXyiBFJgf0ev96UW/ Avlo8v1OUW8FZHT+grDEmFvoCf1EQYTXf2y8rU92pw+Q+VHShRLPPJquM2ACHoJzQTIm D37xknn0D0FNN5heXXSoAPwZAqpZ2P6xt5OhN4bcE0dn1szqhi1U5b7iDRIzaf6SoFC+ yat2mM+dFmgw55FZnpt4RLU4lR01b6DI8Lu80RbMQVNDEJgFHnVKEdisqckypXZG3X2y yV2SlSAfIpvqFXsVbvYna9UTaSJl4+un+CWkzEt9lcSzZ1Q+P/hWamUavTGRlYvp/4Ge eSfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:cc:subject:from:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Ls/VwuyU4BO+1bV+MDNSdcyTHv8Ez1LQ3wxVKdaCZXI=; b=aecQR9+XvCCtZX+XjdUBtSA7GI3yUIwaSRIXsvy5dBVqFE4+7LHNaXgCG6p/tNNbdq egY8FR5nx46Z8uP8kyHeLU1WgHNj68leOZ4wskP+vtPImdIv5w2k40lyEZBjvFH5MYAS EzKv5+qQC95O8nn1CldWCro6kXYueNW/xCsP8HgfZ7o/Tl11+OkB+yqRsr8eW2H9dZY5 XPvroBXTFxDAjNINexVhdIupwms/2Oj/5oiMtKfZ1LTVelV3Iza2r1n9qU9xv4KoeTOo 1Pfxkhh8PftQRah/KbWrjESamWC9pTc+Exqy+myAdqMzw8nL+BP55UO73+k0owUTJxca cBrw== X-Gm-Message-State: AGi0PubatR+ZEyyKtTXYTnkbvluEtdfoaISSTAi9uvJONAQiSKA5KZzU 6Kki9hlk9hl8955cUiTBOY0= X-Google-Smtp-Source: APiQypJP3OF1Y9BNzbsEc/7yw6DZiGcczKUyxV9qovb5k611Du5OwjBOZUb/c4aevAYroPKC175kRQ== X-Received: by 2002:a63:b542:: with SMTP id u2mr2412669pgo.352.1586486015137; Thu, 09 Apr 2020 19:33:35 -0700 (PDT) Received: from localhost (ag027197.dynamic.ppp.asahi-net.or.jp. [157.107.27.197]) by smtp.gmail.com with ESMTPSA id x27sm446514pfj.74.2020.04.09.19.33.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 19:33:34 -0700 (PDT) Date: Fri, 10 Apr 2020 11:33:32 +0900 (JST) Message-Id: <20200410.113332.337305854143176317.horikyota.ntt@gmail.com> To: tgl@sss.pgh.pa.us Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test From: Kyotaro Horiguchi In-Reply-To: <12174.1586467919@sss.pgh.pa.us> References: <20200408.144452.1031907626229663626.horikyota.ntt@gmail.com> <20200409.101339.1252894237035894186.horikyota.ntt@gmail.com> <12174.1586467919@sss.pgh.pa.us> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk At Thu, 09 Apr 2020 17:31:59 -0400, Tom Lane wrote in > Kyotaro Horiguchi writes: > >> Sorry for the wrong test file. > >> Checking in lower precision would be sufficient. > > > I noticed that prailiedog failed in another mode. > > Yeah. We have at least four different buildfarm members complaining > about this test case. I took this patch and further lobotomized the > tests by removing *all* dependencies on restart_lsn and > pg_current_wal_lsn(). If anybody wants to put any of that back, > the burden of proof will be on them to show why we should believe > the results will be stable, not for the buildfarm to demonstrate > that they're not. I think the significant part of the test is wal_status. So I'm not eager to get it back. Thanks! -- Kyotaro Horiguchi NTT Open Source Software Center