Date: Fri, 10 Apr 2020 11:23:45 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP
 test
Message-ID: <20200410152345.GA13282@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200410.113332.337305854143176317.horikyota.ntt@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Apr-10, Kyotaro Horiguchi wrote:

> > Yeah.  We have at least four different buildfarm members complaining
> > about this test case.  I took this patch and further lobotomized the
> > tests by removing *all* dependencies on restart_lsn and
> > pg_current_wal_lsn().  If anybody wants to put any of that back,
> > the burden of proof will be on them to show why we should believe
> > the results will be stable, not for the buildfarm to demonstrate
> > that they're not.
> 
> I think the significant part of the test is wal_status. So I'm not
> eager to get it back.

Agreed.  Thanks for stabilizing it.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services