Date: Mon, 13 Apr 2020 17:49:52 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Use perl warnings pragma consistently
Message-ID: <20200413214952.GA22285@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8t9RHnE3ZwKMSgU+"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <28260.1586813631@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--8t9RHnE3ZwKMSgU+
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2020-Apr-13, Tom Lane wrote:

> Andrew Dunstan <andrew@dunslane.net> writes:
> > Use perl warnings pragma consistently
> 
> This seems to have broken something or other, as I now get a bunch of
> warnings while building the docs:
> 
> ...
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 522.
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 524.
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 526.
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 528.
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 529.

This should fix it.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--8t9RHnE3ZwKMSgU+
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="defined.patch"

diff --git a/doc/src/sgml/mk_feature_tables.pl b/doc/src/sgml/mk_feature_tables.pl
index ee158cb196..a9dfebfbb3 100644
--- a/doc/src/sgml/mk_feature_tables.pl
+++ b/doc/src/sgml/mk_feature_tables.pl
@@ -54,7 +54,9 @@ while (<$feat>)
 	{
 		print "  <entry>$feature_id</entry>\n";
 	}
-	print "  <entry>" . $feature_packages{$feature_id} . "</entry>\n";
+	print "  <entry>",
+		  defined($feature_packages{$feature_id}) ? $feature_packages{$feature_id} : "",
+		  "</entry>\n";
 	if ($subfeature_id)
 	{
 		print "  <entry>$subfeature_name</entry>\n";

--8t9RHnE3ZwKMSgU+--