Date: Wed, 28 Oct 2020 13:41:01 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add pg_relation_check_pages() to check on-disk pages of a
 relati
Message-ID: <20201028044101.GE28445@paquier.xyz>
References: <E1kXbwH-0006Jz-9q@gemulon.postgresql.org>
 <1226629.1603859189@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="sLx0z+5FKKtIVDwd"
Content-Disposition: inline
In-Reply-To: <1226629.1603859189@sss.pgh.pa.us>
Precedence: bulk


--sLx0z+5FKKtIVDwd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 28, 2020 at 12:26:29AM -0400, Tom Lane wrote:
> Seems to have some issues according to florican:
>=20
> 2020-10-28 00:04:53.191 EDT [27031:5] DETAIL:  Failed process was
> running: SELECT relname, failed_block_num FROM (SELECT relname,
> (pg_catalog.pg_relation_check_pages(oid)).*   FROM pg_class    WHERE
> relkind in ('r','i', 'm') AND oid >=3D 16384) AS s=20

Yes, thanks.  I was already investigating it.  No need for a
back-trace, I have been able to reproduce it here avec some -m32'ing
with gcc:
#1  0x566e0572 in fill_val (att=3D0x57d205c0, bit=3D0x0,
bitmask=3D0xff9c51e8, dataP=3D0xff9c521c, infomask=3D0x57d207e8, datum=3D0,
isnull=3Dfalse) at heaptuple.c:287
#2  0x566e066e in heap_fill_tuple (tupleDesc=3D0x57d2053c,
values=3D0xff9c52b0, isnull=3D0xff9c52ae, data=3D0x57d207fd "",
data_size=3D28, infomask=3D0x57d207e8, bit=3D0x0)
at heaptuple.c:336
#3  0x566e2660 in heap_form_minimal_tuple
(tupleDescriptor=3D0x57d2053c, values=3D0xff9c52b0, isnull=3D0xff9c52ae)
at heaptuple.c:1412
#4  0x56d18e84 in tuplestore_putvalues (state=3D0x57d20648,
tdesc=3D0x57d2053c, values=3D0xff9c52b0, isnull=3D0xff9c52ae) at
tuplestore.c:756
#5  0x56c2b94b in check_relation_fork (tupdesc=3D0x57d2053c,
tupstore=3D0x57d20648, relation=3D0xeebf346c, forknum=3DMAIN_FORKNUM) at
pagefuncs.c:222
#6  0x56c2b779 in check_one_relation (tupdesc=3D0x57d2053c,
tupstore=3D0x57d20648, relid=3D16384,
single_forknum=3DInvalidForkNumber) at pagefuncs.c:148
#7  0x56c2b645 in pg_relation_check_pages (fcinfo=3D0x57d1c888) at
pagefuncs.c:104   =20
--
Michael

--sLx0z+5FKKtIVDwd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl+Y9l0ACgkQnvQgOdby
QH1EGhAAiUGH/kLHCWWmIQkrmCbl5BTsIPm4tz6pLGg4pwK1G0T6HvNSlcTJJxA9
S03yNKSLGzdBVvsuy87e/NpiEibxa80Lp46CWdzpX8qmI7r3+YOeHGj9jzqUeHbN
bVgS8FFpSQTpzyszejVrP4zyIDLKGi0KgXMClNqtV6rVNF/9ad1zRmCs0MAJCq7x
/y4OTP0pPxuTPGcSliToZWS9k5snHwSl2cWByyGNwAIe4hTYFrPStc8FV8mDAmxr
XaX2ZS5ZITVpZcIsCqNNO9ThajHdKnxeqFCSbKDW024cMck6hGadgdbVcWT8DA1A
0Uv3wPM6lHi8W//08bN1cLQ2U7i7ZEvwYIEP7Z3nCdaFfZILSPhUK5jFsL4CGDR9
K8MmVw/8C1tCWPg1aS6TpIb++24xrn+avbAVp5suoIgsmLNpm7ffzNn0Tmy7T4vT
8/rFYIhEIihccmk+wTx0stwua+dkJ1cikJt9/wJykFdujjf5lLzZ8DcDorSmAjVr
pozd3hDynGFPj2LmrGpVru/YT+bBy/l3jNnJwwA5pZ28/L9FgDvvOPX1aqD3sh0G
ws7ckDa8ZnlR5Fol0iAKlHxQitDIEC/VCe+HQ/JrcBSdjAL8LK8FZlcCG7XOsswI
04ZLtinfYOysmcjwRBbkjphXA31xjKlLo7bQmmf0q+oPdKRy904=
=997M
-----END PGP SIGNATURE-----

--sLx0z+5FKKtIVDwd--