Date: Thu, 12 Nov 2020 17:29:00 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc:  clarify where to find pg_type_d.h (PG 11+) and
 pg_type.h
Message-ID: <20201112202900.GA28098@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1kdIy8-0005Xl-AT@gemulon.postgresql.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Nov-12, Bruce Momjian wrote:

> doc:  clarify where to find pg_type_d.h (PG 11+) and pg_type.h
> 
> These files are in compiled directories and install directories.

I think this patch is wrong, because in the install tree the files are in
the server/ subdir.  It should read:

	The <acronym>OID</acronym>s of the built-in data types are defined in
	the file <filename>include/catalog/pg_type_d.h</filename> in the
	compiled source directory, and in
	<filename>include/server/catalog/pg_type_d.h</filename> in the install
	directory.

That said, if the user is doing a VPATH build, then "compiled source
directory" is a confusing way to say "the build directory", and I don't
think it's an important location anyway, first because it's really a
throwaway directory, and second it's not even there in a packaged
installation; users just care about the *installed* file, don't they?
So I suggest to rip that part out, and leave just:

	The <acronym>OID</acronym>s of the built-in data types are defined in
	the file <filename>include/server/catalog/pg_type_d.h</filename> in the
	install directory.