Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1kdLov-0006xZ-F3
	for pgsql-committers@arkaria.postgresql.org; Thu, 12 Nov 2020 23:16:01 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1kdLou-00059e-8d
	for pgsql-committers@arkaria.postgresql.org; Thu, 12 Nov 2020 23:16:00 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kdLou-00059X-3J
	for pgsql-committers@lists.postgresql.org; Thu, 12 Nov 2020 23:16:00 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kdLon-00060x-8K
	for pgsql-committers@lists.postgresql.org; Thu, 12 Nov 2020 23:15:59 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1kdLol-0003w4-Uk; Thu, 12 Nov 2020 18:15:51 -0500
Date: Thu, 12 Nov 2020 18:15:51 -0500
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc:  clarify where to find pg_type_d.h (PG 11+) and
 pg_type.h
Message-ID: <20201112231551.GF4506@momjian.us>
References: <E1kdIy8-0005Xl-AT@gemulon.postgresql.org>
 <20201112202900.GA28098@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="oC1+HKm2/end4ao3"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201112202900.GA28098@alvherre.pgsql>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk


--oC1+HKm2/end4ao3
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Thu, Nov 12, 2020 at 05:29:00PM -0300, Álvaro Herrera wrote:
> On 2020-Nov-12, Bruce Momjian wrote:
> 
> > doc:  clarify where to find pg_type_d.h (PG 11+) and pg_type.h
> > 
> > These files are in compiled directories and install directories.
> 
> I think this patch is wrong, because in the install tree the files are in
> the server/ subdir.  It should read:
> 
> 	The <acronym>OID</acronym>s of the built-in data types are defined in
> 	the file <filename>include/catalog/pg_type_d.h</filename> in the
> 	compiled source directory, and in
> 	<filename>include/server/catalog/pg_type_d.h</filename> in the install
> 	directory.
> 
> That said, if the user is doing a VPATH build, then "compiled source
> directory" is a confusing way to say "the build directory", and I don't
> think it's an important location anyway, first because it's really a
> throwaway directory, and second it's not even there in a packaged
> installation; users just care about the *installed* file, don't they?
> So I suggest to rip that part out, and leave just:
> 
> 	The <acronym>OID</acronym>s of the built-in data types are defined in
> 	the file <filename>include/server/catalog/pg_type_d.h</filename> in the
> 	install directory.

OK, how is this followup patch?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee


--oC1+HKm2/end4ao3
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="pg_type-v2.diff"

diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 73c6a6ea4d..9d4b6ab4a8 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -3666,8 +3666,8 @@ Oid PQftype(const PGresult *res,
        You can query the system table <literal>pg_type</literal> to
        obtain the names and properties of the various data types. The
        <acronym>OID</acronym>s of the built-in data types are defined
-       in the file <filename>include/catalog/pg_type_d.h</filename>
-       in the compiled source directory and install directory.
+       in the file <filename>include/server/catalog/pg_type_d.h</filename>
+       in the install directory.
       </para>
      </listitem>
     </varlistentry>

--oC1+HKm2/end4ao3--