Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l57mp-0002PH-As for pgsql-committers@arkaria.postgresql.org; Thu, 28 Jan 2021 13:56:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l57mo-0007bM-98 for pgsql-committers@arkaria.postgresql.org; Thu, 28 Jan 2021 13:56:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l57mn-0007bF-Fg for pgsql-committers@lists.postgresql.org; Thu, 28 Jan 2021 13:56:38 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l57ml-0002uJ-5H for pgsql-committers@lists.postgresql.org; Thu, 28 Jan 2021 13:56:36 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 189B75C00B8; Thu, 28 Jan 2021 08:56:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 28 Jan 2021 08:56:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=QDirAgYkyYcFhHmSGPTWjtvOOBdEcAxYCIL6O4KkoEc=; b=UzAjmGFh YO2mJ1Hv08UxADUNWTN4is33vBKw7BTRSe0RrnUYdT7dphzYq8mYyj+7t3/JoeFr M9E2isvtSTlYofh3rPQLcmiXnPlEiqou4rtofNPSgLzBLfrwzw2Fzu6fEVbbybNb Sr0V5hxl2ky9rgjq682qOyZhZcpjABcXY/PPKljdlEZLf31klz87KRjRBG9WesI6 k5l+CaP/8MwQ8Iqcacin6rQdYhNNfrfPSS8NIJ8Mo/i0Nf3YbyscA8W7COZShf1u Ckb1pENSDBy6RIMABvn6nvjrrmMuNNKenw9Yv5rdbTGkmm6U2Theu7ZV+k46ww3G t4ScueO5jwMKJw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtugfgjggfsehtkeertddtredunecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeeufffhjeeiueeuffegvddukeegledtveeivdeiueefieei vefgteehueefteehvdenucfkphepudeltddrleehrdduledrudejjeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghl vhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.177]) by mail.messagingengine.com (Postfix) with ESMTPA id 8C53024005A; Thu, 28 Jan 2021 08:56:32 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id BA72B2A0D41; Thu, 28 Jan 2021 10:56:29 -0300 (-03) Date: Thu, 28 Jan 2021 10:56:29 -0300 From: Alvaro Herrera To: Michael Paquier Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Refactor code in tablecmds.c to check and process tablespace mov Message-ID: <20210128135629.GA30534@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2021-Jan-28, Michael Paquier wrote: > So, for now, I would just do the attached to address your > suggestions. Is that fine for you? Yep, seems OK to me, assuming that, as you say, you'll update the comments again when they are used to handle the concurrent cases. Thanks! -- Álvaro Herrera Valdivia, Chile "There was no reply" (Kernel Traffic)