Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJkcW-0002Vm-Pq for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Aug 2021 22:46:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mJkcV-0001Rm-5r for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Aug 2021 22:46:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJkcU-0001QI-TG for pgsql-hackers@lists.postgresql.org; Fri, 27 Aug 2021 22:46:42 +0000 Received: from tamriel.snowman.net ([70.109.60.50]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mJkcR-0005ZC-Rx for pgsql-hackers@lists.postgresql.org; Fri, 27 Aug 2021 22:46:42 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 45EBE5F799; Fri, 27 Aug 2021 18:46:39 -0400 (EDT) Date: Fri, 27 Aug 2021 18:46:39 -0400 From: Stephen Frost To: Andres Freund Cc: pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Deduplicate choice of horizon for a relation procarray.c. Message-ID: <20210827224639.GX17906@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LlfqcAVf8KvGQgdk" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --LlfqcAVf8KvGQgdk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Andres Freund (andres@anarazel.de) wrote: > As the code in question was only introduced in dc7420c2c92 it seems worth > backpatching this change as well, otherwise 14 will look different from a= ll > other branches. Interestingly, these patches ended up actually introducing a difference between 14 and master in the form of: GlobalVisTestFor(Relation rel) - GlobalVisState *state; + GlobalVisState *state =3D NULL; being done on master but not in the 14 stable branch, leading to, at least for me: =2E../src/backend/storage/ipc/procarray.c: In function =E2=80=98GlobalVisTe= stFor=E2=80=99: =2E../src/backend/storage/ipc/procarray.c:4054:9: warning: =E2=80=98state= =E2=80=99 may be used uninitialized in this function [-Wmaybe-uninitialized] 4054 | return state; | ^~~~~ Seems like we should include that change in 14 too, to get rid of the above warning and to make that bit of code the same too..? Thanks! Stephen --LlfqcAVf8KvGQgdk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJhKWtOAAoJEO1sijiDR2RVR8EQAMSz0PENQS7HtM1mc7X5aGnV c1Qh2CPpNrxCE/5bzrKUWDoUUZAXAF293qihkWMRcuXPbO/a96jmJs9nn93J1nqT FONdDCoDoFauaV3NF7KyAvBW8yKtJiWfRADfGvK2zgiDyD2iWyHdwx9WE2JhFGtk mrW6xu0g2kaVlu0lUjXP/eMvPKMDXc1BQT91mF09ssKwp8F3uZMdd0jyuKL4aEBQ M4qFveRjERyzwY4pOJ8teXiU9VETq0QWoZDSjYIWC2vLReaqB4btCw4k82k6cUtM hrRfpAw1ajTcPKfF9jKqeplmwg5yed3tTOMpK8tLpGYuwk1xkx2xJkTe8IQndfiZ moA1FefVBHgqmoyqZg5DfiTt8AIKHk0+4VTUQ4K1Z1si/ukI7gvsGgU5LgPjenBF /uSPds9lt62U2/CAbcZbZSWhnI/NG5O8+v3QqMWmzp1y4ELvI6x0iB6XVdZgIp+M VRyym8WGoSPOjuDdoS9TtvYtrdAGUWUpFlPejHGsoakjtxIF3pWT3/JTmWQeEFtC 0Ga94nZUjSwr3cgXjpzw0Zo6vkxZ8A5dDdlIv/gBvbJbQ/g7tnw/1p+EC2FJkeRD UCBQaeh3Af23NgGAoaYD+xGW6D4DAxn9KJHEQmUpI9AnFIkkpObwD7vavn+4agzI Jx8f9wssp1+ua+Vf8jJB =y/hO -----END PGP SIGNATURE----- --LlfqcAVf8KvGQgdk--