pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Set the volatility of the timestamptz version of date_bin() back
8+ messages / 5 participants
[nested] [flat]
* pgsql: Set the volatility of the timestamptz version of date_bin() back
@ 2021-09-03 17:42 John Naylor <john.naylor@postgresql.org>
0 siblings, 2 replies; 8+ messages in thread
From: John Naylor @ 2021-09-03 17:42 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Set the volatility of the timestamptz version of date_bin() back to immutable
543f36b43d was too hasty in thinking that the volatility of date_bin()
had to match date_trunc(), since only the latter references
session_timezone.
Bump catversion
Per feedback from Aleksander Alekseev
Backpatch to v14, as the former commit was
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/67c33a114f38edbd66f68d7b2c0cb7b03611ec48
Modified Files
--------------
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Set the volatility of the timestamptz version of date_bin() back
@ 2021-09-03 17:42 John Naylor <john.naylor@postgresql.org>
0 siblings, 0 replies; 8+ messages in thread
From: John Naylor @ 2021-09-03 17:42 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Set the volatility of the timestamptz version of date_bin() back to immutable
543f36b43d was too hasty in thinking that the volatility of date_bin()
had to match date_trunc(), since only the latter references
session_timezone.
Bump catversion
Per feedback from Aleksander Alekseev
Backpatch to v14, as the former commit was
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0c6a6a0ab7675e151a6e46d3ec0846bfce9e030a
Modified Files
--------------
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: Set the volatility of the timestamptz version of date_bin() back
@ 2021-09-03 17:45 Alvaro Herrera <alvherre@alvh.no-ip.org>
parent: John Naylor <john.naylor@postgresql.org>
1 sibling, 1 reply; 8+ messages in thread
From: Alvaro Herrera @ 2021-09-03 17:45 UTC (permalink / raw)
To: John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-hackers@lists.postgresql.org
On 2021-Sep-03, John Naylor wrote:
> Set the volatility of the timestamptz version of date_bin() back to immutable
>
> 543f36b43d was too hasty in thinking that the volatility of date_bin()
> had to match date_trunc(), since only the latter references
> session_timezone.
>
> Bump catversion
These catversion bumps in branch 14 this late in the cycle seem suspect.
Didn't we have some hesitation to push multirange unnest around beta2
precisely because of a desire to avoid catversion bumps?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: Set the volatility of the timestamptz version of date_bin() back
@ 2021-09-03 17:50 John Naylor <john.naylor@enterprisedb.com>
parent: Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 8+ messages in thread
From: John Naylor @ 2021-09-03 17:50 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: John Naylor <john.naylor@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, Sep 3, 2021 at 1:46 PM Alvaro Herrera <alvherre@alvh.no-ip.org>
wrote:
>
> On 2021-Sep-03, John Naylor wrote:
> These catversion bumps in branch 14 this late in the cycle seem suspect.
> Didn't we have some hesitation to push multirange unnest around beta2
> precisely because of a desire to avoid catversion bumps?
This was for correcting a mistake (although the first commit turned out to
be a mistake itself), so I understood it to be necessary.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: Set the volatility of the timestamptz version of date_bin() back
@ 2021-09-03 17:56 Alvaro Herrera <alvherre@alvh.no-ip.org>
parent: John Naylor <john.naylor@enterprisedb.com>
0 siblings, 2 replies; 8+ messages in thread
From: Alvaro Herrera @ 2021-09-03 17:56 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: John Naylor <john.naylor@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 2021-Sep-03, John Naylor wrote:
> On Fri, Sep 3, 2021 at 1:46 PM Alvaro Herrera <alvherre@alvh.no-ip.org>
> wrote:
> >
> > On 2021-Sep-03, John Naylor wrote:
> > These catversion bumps in branch 14 this late in the cycle seem suspect.
> > Didn't we have some hesitation to push multirange unnest around beta2
> > precisely because of a desire to avoid catversion bumps?
>
> This was for correcting a mistake (although the first commit turned out to
> be a mistake itself), so I understood it to be necessary.
A crazy idea might have been to return to the original value.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: Set the volatility of the timestamptz version of date_bin() back
@ 2021-09-03 18:27 Justin Pryzby <pryzby@telsasoft.com>
parent: Alvaro Herrera <alvherre@alvh.no-ip.org>
1 sibling, 0 replies; 8+ messages in thread
From: Justin Pryzby @ 2021-09-03 18:27 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: John Naylor <john.naylor@enterprisedb.com>; John Naylor <john.naylor@postgresql.org>; pgsql-hackers@lists.postgresql.org
On Fri, Sep 03, 2021 at 01:56:50PM -0400, Alvaro Herrera wrote:
> On 2021-Sep-03, John Naylor wrote:
>
> > On Fri, Sep 3, 2021 at 1:46 PM Alvaro Herrera <alvherre@alvh.no-ip.org>
> > wrote:
> > >
> > > On 2021-Sep-03, John Naylor wrote:
> > > These catversion bumps in branch 14 this late in the cycle seem suspect.
> > > Didn't we have some hesitation to push multirange unnest around beta2
> > > precisely because of a desire to avoid catversion bumps?
> >
> > This was for correcting a mistake (although the first commit turned out to
> > be a mistake itself), so I understood it to be necessary.
>
> A crazy idea might have been to return to the original value.
+1. I think the catversion usually is always increased even in a "revert", but
in this exceptional case [0] it would be nice if beta4/rc1 had the same number
as b3.
[0] two commits close to each other, with no other catalog changes, and with
the specific goal of allowing trivial upgrade from b3.
--
Justin
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: Set the volatility of the timestamptz version of date_bin() back
@ 2021-09-03 20:42 Tom Lane <tgl@sss.pgh.pa.us>
parent: John Naylor <john.naylor@postgresql.org>
1 sibling, 0 replies; 8+ messages in thread
From: Tom Lane @ 2021-09-03 20:42 UTC (permalink / raw)
To: John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
John Naylor <john.naylor@postgresql.org> writes:
> Set the volatility of the timestamptz version of date_bin() back to immutable
> 543f36b43d was too hasty in thinking that the volatility of date_bin()
> had to match date_trunc(), since only the latter references
> session_timezone.
> Bump catversion
What you should have done here, at least in the back branch, was *revert*
catversion to what it had been. As things stand, it would force users of
14beta3 to initdb or pg_upgrade to move to 14.0, for no reason whatsoever.
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: Set the volatility of the timestamptz version of date_bin() back
@ 2021-09-03 20:47 Tom Lane <tgl@sss.pgh.pa.us>
parent: Alvaro Herrera <alvherre@alvh.no-ip.org>
1 sibling, 0 replies; 8+ messages in thread
From: Tom Lane @ 2021-09-03 20:47 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: John Naylor <john.naylor@enterprisedb.com>; John Naylor <john.naylor@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2021-Sep-03, John Naylor wrote:
>> On Fri, Sep 3, 2021 at 1:46 PM Alvaro Herrera <alvherre@alvh.no-ip.org>
>> wrote:
>>> These catversion bumps in branch 14 this late in the cycle seem suspect.
>>> Didn't we have some hesitation to push multirange unnest around beta2
>>> precisely because of a desire to avoid catversion bumps?
>> This was for correcting a mistake (although the first commit turned out to
>> be a mistake itself), so I understood it to be necessary.
> A crazy idea might have been to return to the original value.
Yes, that is what should have been done, as I complained over
in pgsql-committers before seeing this exchange. As things
stand, a pg_upgrade is going to be forced on beta3 users
without even the excuse of fixing a bug.
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2021-09-03 20:47 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 17:42 pgsql: Set the volatility of the timestamptz version of date_bin() back John Naylor <john.naylor@postgresql.org>
2021-09-03 17:42 pgsql: Set the volatility of the timestamptz version of date_bin() back John Naylor <john.naylor@postgresql.org>
2021-09-03 17:45 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-09-03 17:50 ` John Naylor <john.naylor@enterprisedb.com>
2021-09-03 17:56 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-09-03 18:27 ` Justin Pryzby <pryzby@telsasoft.com>
2021-09-03 20:47 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-09-03 20:42 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox